[16.0][IMP] bi_sql_editor #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
legalsylvain
commented
Dec 5, 2023
•
legalsylvain
commented
- [IMP] Make installation idem potens
- [REF] simplify tests
- [FIX] allow to pass default values in copy() function
- [FIX] do not allow to create model (and sql views) if related model are not set on many2one fields. It prevents the error 'AttributeError: '_unknown' object has no attribute 'id''
- [FIX] Use correct key word 'optional'. (and not 'option') in tree view
- [IMP] allow to reset to the previous state, and not only into 'draft' state
- [REF] simplification : Remove conditional display related to field_description, as this field is required and so, allways defined
- [REM] option_context_field field, as it is now possible to implement that feature with optional='hide' on the field list view
- [IMP] Allow to change fields settings if state is 'Model Valid'. Avoid to reset to draft and to have to recreate view that can take a while, if the view is materialized
- [IMP] Improve code coverage, adding various settings on field items
legalsylvain
force-pushed
the
16.0-IMP-bi_sql_editor
branch
from
1fa1f9c to
4aa882a
Compare
[FIX] bi_sql_editor : allow to pass default values in copy() function
… related model are not set on many2one fields. It prevents the error 'AttributeError: '_unknown' object has no attribute 'id''
…on') in tree view
…nly into 'draft' state
…ated to field_description, as this field is required and so, allways defined
…le to implement that feature with optional='hide' on the field list view
…del Valid'. Avoid to reset to draft and to have to recreate view that can take a while, if the view is materialized
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c36a86d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.