-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] [16.0] purchase_allowed_product: Improve UX #2155
[FIX] [16.0] purchase_allowed_product: Improve UX #2155
Conversation
- Make use_only_supplied_product field computed, stored and not readonly - Propagation of use_only_supplied_product field to invoices
1eecb18
to
7497fe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM https://www.loom.com/share/9b2d2feaca90429b89474dda395e68db?sid=a1b1e212-644e-4835-acae-321bb0ed182f
As a suggestion, when entering to validate delivery notes and returning through the breadcrumb trail, the button disappears. ¿Is OK? https://www.loom.com/share/8fff4032c3d2452388760430a6de753a?sid=2edce4c7-d913-4e0a-8b75-2eb56ae67ba5
I guess it's not within the scope of this PR, but indeed, it'd make sense to make the field visible for confirmed orders as well since you can still add products to those unless configured otherwise. |
You always can add products to purchase order, so makes sense to be able to see the check/switch always
@Gelojr @yostashiro makes totally sense. Done in a separate commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 3ead3e0. Thanks a lot for contributing to OCA. ❤️ |
use_only_supplied_product
field always visible on Purchase Orders (check comments)https://www.loom.com/share/6987c27348134673a7cae67c8ca43920?sid=7d980b6f-0917-4f7e-973c-1dac484d423e
MT-4264 @moduon @rafaelbn @fcvalgar @Gelojr plz review :)