-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][mig] purchase_blanket_order: Migration to 16.0 #1908
Conversation
The default behavior in a PO is that the purchsing UoM is used as the PO line UoM when set in the product. Blanket Orders should do the same, otherwise it is a bit confusing.
…rders from date_start desc field. TT37792
Current behavior: - Create a blanket order and confirm > PBO/0001 - Convert to draft - Confirm > PBO/0001 (Previously the name was changed to another sequence PBO/0002). TT37792
…ate. Sales blanket orders had the same description, at least one of the two should change to reduce confusion.
Currently the check for assigning a new sequence is done over a translatable string, but the initial sequence name is not done being translatable, so we should make both to compare the same string. TT37792
Before this change there was the following inconsistency: - Create a blanket order. - Create a line with product A and price 1. - Confirm. - Cancel + return to draft (to be able to modify the price of the line). - Change the price to 2. - The status is automatically changed to open (without being able to modify the line). TT39646
…event inconsistencies TT39646
…etting to state open after being cancelled and edit on draft
…16.0-mig-purchase_blanket_order
@dsolanki-initos Are you still working on this PR? If so, could you add this commit please #2048 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes required.
<field | ||
name="product_id" | ||
context="{'partner_id':parent.partner_id, 'quantity':original_uom_qty, 'company_id': parent.company_id}" | ||
groups="base.group_multi_company" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not make sense to add this group.
name="original_uom_qty" | ||
string="Original Qty" | ||
context="{'partner_id':parent.partner_id, 'quantity':original_uom_qty, 'company_id': parent.company_id}" | ||
groups="base.group_multi_company" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not make sense to add this group.
<field | ||
name="product_id" | ||
context="{'partner_id':parent.partner_id, 'quantity':original_uom_qty, 'company_id': parent.company_id}" | ||
groups="base.group_multi_company" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not make sense to add
name="original_uom_qty" | ||
string="Original Qty" | ||
context="{'partner_id':parent.partner_id, 'quantity':original_uom_qty, 'company_id': parent.company_id}" | ||
groups="base.group_multi_company" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not make sense to add
Depends on
Web/web_action_conditionable