[IMP] project_timesheet_time_control: Tell the user no running line was found #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
changed the title
…as found Imagine this scenario: 1. In tab 1 of the browser, you have opened task 1. 2. In tab 2 of the browser, you have opened task 2. 3. You go to tab 1 and start a timer. 4. Work, work, work... 5. You go to tab 2 and start a timer, stopping that of task 1. 6. Work, work, work... 7. You go to tab 1 and see that timer as running (it is not, but you didn't refresh). You hit stop. Before this commit, it just seemed like the timer was actually stopped. What did happen behind the scenes is that your view was refreshed, but no timer was touched fortunately. After this commit, you get a message telling you that there's no timer to stop and that your browser is most likely out of sync. This mimics the behavior previously found when doing the same, but directly in the AAL. Now it's present in projects and tasks too.
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
df5ed82 to
d9e5e37
Compare
pedrobaeza
requested changes
Oct 15, 2019
|
Also there's no possibility of avoiding code duplication? |
|
Maybe with a mixin. Do you think it's worth it? |
|
Well, I'm seeing a lot of code duplication, also in OCA/timesheet#280, so I think we can explore that possibility |
|
Can we merge and leave that for later? 🙄 |
|
I prefer to do it now. |
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically.
yajo
added a commit
to Tecnativa/timesheet
that referenced
this pull request
Oct 15, 2019
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
|
OK, done. |
pedrobaeza
approved these changes
Oct 15, 2019
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 15, 2019
|
Congratulations, your PR was merged at ab8b30a. Thanks a lot for contributing to OCA. ❤️ |
manuelcalerosolis
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Feb 27, 2020
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
pedrobaeza
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Sep 26, 2020
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
fshah-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
Mar 15, 2021
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
fshah-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
Mar 31, 2021
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
hkapatel-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
Sep 3, 2021
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
LudLaf
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Nov 21, 2022
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
pedrobaeza
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Nov 27, 2022
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
carolinafernandez-tecnativa
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Sep 25, 2023
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
carolinafernandez-tecnativa
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Sep 25, 2023
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
mde-scopea
pushed a commit
to mde-scopea/timesheet
that referenced
this pull request
Jan 31, 2024
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
RogerSans
pushed a commit
to sygel-technology/timesheet
that referenced
this pull request
Jul 29, 2024
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
jdebetaz
pushed a commit
to jdebetaz/oca-timesheet
that referenced
this pull request
Jan 15, 2025
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine this scenario:
Before this commit, it just seemed like the timer was actually stopped. What did happen behind the scenes is that your view was refreshed, but no timer was touched fortunately.
After this commit, you get a message telling you that there's no timer to stop and that your browser is most likely out of sync. This mimics the behavior previously found when doing the same, but directly in the AAL. Now it's present in projects and tasks too.
@Tecnativa TT19205 OCA/timesheet#280