[MIG] partner_identification: Migration to 16.0

OCA · Nov 29, 2022 · 48069ed · 48069ed
1 parent 871035c
commit 48069ed
Show file tree

Hide file tree

Showing 10 changed files with 33 additions and 27 deletions.
diff --git a/partner_identification/README.rst b/partner_identification/README.rst
@@ -14,13 +14,13 @@ Partner Identification Numbers
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github
-    :target: https://github.com/OCA/partner-contact/tree/14.0/partner_identification
+    :target: https://github.com/OCA/partner-contact/tree/16.0/partner_identification
     :alt: OCA/partner-contact
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_identification
+    :target: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_identification
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
-    :target: https://runbot.odoo-community.org/runbot/134/14.0
+    :target: https://runbot.odoo-community.org/runbot/134/16.0
     :alt: Try me on Runbot
 
 |badge1| |badge2| |badge3| |badge4| |badge5| 
@@ -97,7 +97,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/partner-contact/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_identification%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_identification%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -126,6 +126,7 @@ Contributors
 * Simone Orsi <[email protected]>
 * Dennis Sluijk <[email protected]>
 * Phuc Tran Thanh <[email protected]>
+* Marie Lejeune <[email protected]>
 
 Other credits
 ~~~~~~~~~~~~~
@@ -147,6 +148,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/partner-contact <https://github.com/OCA/partner-contact/tree/14.0/partner_identification>`_ project on GitHub.
+This module is part of the `OCA/partner-contact <https://github.com/OCA/partner-contact/tree/16.0/partner_identification>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/partner_identification/__manifest__.py b/partner_identification/__manifest__.py
@@ -9,7 +9,7 @@
 {
     "name": "Partner Identification Numbers",
     "category": "Customer Relationship Management",
-    "version": "14.0.1.3.0",
+    "version": "16.0.1.0.0",
     "license": "AGPL-3",
     "depends": ["contacts"],
     "data": [

diff --git a/partner_identification/models/res_partner.py b/partner_identification/models/res_partner.py
@@ -125,11 +125,15 @@ def _inverse_identification(self, field_name, category_code):
             else:
                 raise ValidationError(
                     _(
-                        "This %s has multiple IDs of this type (%s), so a write "
-                        "via the %s field is not possible. In order to fix this, "
-                        "please use the IDs tab."
+                        "This {record_name} has multiple IDs of this "
+                        "type ({category_code}), so a write via the "
+                        "{field_name} field is not possible. "
+                        "In order to fix this, please use the IDs tab."
+                    ).format(
+                        record_name=record._name,
+                        category_code=category_code,
+                        field_name=field_name,
                     )
-                    % (record._name, category_code, field_name)
                 )
 
     @api.model

diff --git a/partner_identification/models/res_partner_id_category.py b/partner_identification/models/res_partner_id_category.py
@@ -25,8 +25,6 @@ def _get_default_color(self):
 
     color = fields.Integer(string="Color Index", default=_get_default_color)
     code = fields.Char(
-        string="Code",
-        size=16,
         required=True,
         help="Abbreviation or acronym of this ID type. For example, "
         "'driver_license'",
@@ -37,7 +35,7 @@ def _get_default_color(self):
         translate=True,
         help="Name of this ID type. For example, 'Driver License'",
     )
-    active = fields.Boolean(string="Active", default=True)
+    active = fields.Boolean(default=True)
     validation_code = fields.Text(
         "Python validation code", help="Python code called to validate an id number."
     )
@@ -60,12 +58,13 @@ def validate_id_number(self, id_number):
         except Exception as e:
             raise UserError(
                 _(
-                    "Error when evaluating the id_category validation code:"
-                    ":\n %s \n(%s)"
-                )
-                % (self.name, e)
-            )
+                    "Error when evaluating the id_category "
+                    "validation code: \n {name} \n({error})"
+                ).format(name=self.name, error=e)
+            ) from e
         if eval_context.get("failed", False):
             raise ValidationError(
-                _("%s is not a valid %s identifier") % (id_number.name, self.name)
+                _("{id_name} is not a valid {cat_name} identifier").format(
+                    id_name=id_number.name, cat_name=self.name
+                )
             )
diff --git a/partner_identification/models/res_partner_id_number.py b/partner_identification/models/res_partner_id_number.py
@@ -67,7 +67,7 @@ def validate_id_number(self):
             ("close", "Expired"),
         ]
     )
-    active = fields.Boolean(string="Active", default=True)
+    active = fields.Boolean(default=True)
 
     @api.model
     def default_get(self, fields):

diff --git a/partner_identification/readme/CONTRIBUTORS.rst b/partner_identification/readme/CONTRIBUTORS.rst
@@ -7,3 +7,4 @@
 * Simone Orsi <[email protected]>
 * Dennis Sluijk <[email protected]>
 * Phuc Tran Thanh <[email protected]>
+* Marie Lejeune <[email protected]>
diff --git a/partner_identification/static/description/index.html b/partner_identification/static/description/index.html
@@ -3,7 +3,7 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils 0.15.1: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
 <title>Partner Identification Numbers</title>
 <style type="text/css">
 
@@ -367,7 +367,7 @@ <h1 class="title">Partner Identification Numbers</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/partner-contact/tree/14.0/partner_identification"><img alt="OCA/partner-contact" src="https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_identification"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/134/14.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/partner-contact/tree/16.0/partner_identification"><img alt="OCA/partner-contact" src="https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_identification"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/134/16.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
 <p>This module allows to manage all sort of identification numbers
 and certificates which are assigned to a partner (company or individual)
 and vary from country to country.</p>
@@ -451,7 +451,7 @@ <h1><a class="toc-backref" href="#id4">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/partner-contact/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us smashing it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_identification%0Aversion:%2014.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/partner-contact/issues/new?body=module:%20partner_identification%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -479,6 +479,7 @@ <h2><a class="toc-backref" href="#id7">Contributors</a></h2>
 <li>Simone Orsi &lt;<a class="reference external" href="mailto:simone.orsi&#64;camptocamp.com">simone.orsi&#64;camptocamp.com</a>&gt;</li>
 <li>Dennis Sluijk &lt;<a class="reference external" href="mailto:d.sluijk&#64;onestein.nl">d.sluijk&#64;onestein.nl</a>&gt;</li>
 <li>Phuc Tran Thanh &lt;<a class="reference external" href="mailto:phuc&#64;trobz.com">phuc&#64;trobz.com</a>&gt;</li>
+<li>Marie Lejeune &lt;<a class="reference external" href="mailto:marie.lejeune&#64;acsone.eu">marie.lejeune&#64;acsone.eu</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="other-credits">
@@ -495,7 +496,7 @@ <h2><a class="toc-backref" href="#id9">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/partner-contact/tree/14.0/partner_identification">OCA/partner-contact</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/partner-contact/tree/16.0/partner_identification">OCA/partner-contact</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

diff --git a/partner_identification/tests/test_res_partner.py b/partner_identification/tests/test_res_partner.py
@@ -7,7 +7,7 @@
 from .fake_models import ResPartner, setup_test_model, teardown_test_model
 
 
-class TestResPartner(common.SavepointCase):
+class TestResPartner(common.TransactionCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()

diff --git a/partner_identification/views/res_partner_id_category_view.xml b/partner_identification/views/res_partner_id_category_view.xml
@@ -47,7 +47,7 @@ failed = not id_number.name.startswith(self.code) and True or False
         <field name="model">res.partner.id_category</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="Partner Identification Categories">
+            <tree>
                 <field name="name" />
                 <field name="code" />
             </tree>

diff --git a/partner_identification/views/res_partner_id_number_view.xml b/partner_identification/views/res_partner_id_number_view.xml
@@ -27,7 +27,7 @@
         <field name="model">res.partner.id_number</field>
         <field name="type">tree</field>
         <field name="arch" type="xml">
-            <tree string="Partner ID Numbers">
+            <tree>
                 <field name="partner_id" />
                 <field name="category_id" />
                 <field name="name" />