Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] hr_contract_operating_unit #481

Merged
merged 18 commits into from
Jan 15, 2023
Merged

[15.0][MIG] hr_contract_operating_unit #481

merged 18 commits into from
Jan 15, 2023

Conversation

JuanyDForgeflow
Copy link

This module introduces the following features:

  • Adds the Operating Unit (OU) to the Employee Contract.

  • Security rules are defined to ensure that users can only see the Contracts of that Operating Units in which they are allowed access to.

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-hr_contract_operating_unit branch 3 times, most recently from a42d16d to d6748a9 Compare June 21, 2022 00:19
@JuanyDForgeflow JuanyDForgeflow mentioned this pull request Jun 21, 2022
Closed
30 tasks
@AaronHForgeFlow
Copy link
Contributor

/ocabot migration hr_contract_operating_unit

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 2, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 11, 2022
BT-apadron
BT-apadron approved these changes Jan 9, 2023
View reviewed changes
Copy link

@BT-apadron BT-apadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow AaronHForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jan 10, 2023
@AaronHForgeFlow
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow The rebase process failed, because command git push --force ForgeFlow tmp-pr-481:15.0-mig-hr_contract_operating_unit failed with output:

remote: Permission to ForgeFlow/operating-unit.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/operating-unit/': The requested URL returned error: 403

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-hr_contract_operating_unit branch from d6748a9 to 97e1070 Compare January 10, 2023 13:44
@AaronHForgeFlow
Copy link
Contributor

@JuanyDForgeflow can you check pre-commit?

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-hr_contract_operating_unit branch from 97e1070 to d069339 Compare January 10, 2023 15:55
@JuanyDForgeflow
Copy link
Author

@AaronHForgeFlow Done

@AaronHForgeFlow
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow The rebase process failed, because command git push --force ForgeFlow tmp-pr-481:15.0-mig-hr_contract_operating_unit failed with output:

remote: Permission to ForgeFlow/operating-unit.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/operating-unit/': The requested URL returned error: 403

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-hr_contract_operating_unit branch from d069339 to 82acea2 Compare January 13, 2023 19:13
AaronHForgeFlow
AaronHForgeFlow requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot, When creating a new contract I cannot create a new contract in a different operating unit that main operating unit. If I put B2B as the default operating unit, The contract will have this operating unit, but if I try to select any other, then only Main OU is available again.

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-hr_contract_operating_unit branch 4 times, most recently from 9e7b5db to caef573 Compare January 13, 2023 21:58
@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-hr_contract_operating_unit branch from caef573 to a7c3db4 Compare January 13, 2023 22:01
@JuanyDForgeflow
Copy link
Author

@AaronHForgeFlow It's fixed now

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 15, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-481-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 170a5c6 into OCA:15.0 Jan 15, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ff7ed41. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@BT-apadron BT-apadron BT-apadron approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
9 participants
@JuanyDForgeflow @AaronHForgeFlow @OCA-git-bot @BT-apadron @SerpentCS @serpentcs-dev1 @AdriaGForgeFlow @oca-travis @pedrocs-exo