Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] [MIG] Migrated crm_operating_unit #442

Closed
wants to merge 26 commits into from
Closed

[15.0] [MIG] Migrated crm_operating_unit #442

wants to merge 26 commits into from

Conversation

Rajan-SCS
Copy link
Contributor

No description provided.

@AaronHForgeFlow
Copy link
Contributor

Hi @Rajan-SCS thanks for the PR. Can you check why the commit messages has been renamed? All of them has the header [PATCH X/25] that is not the actual original commit message

@AaronHForgeFlow
Copy link
Contributor

/ocabot migration crm_operating_unit

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 13, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 13, 2022
Closed
30 tasks
@Rajan-SCS Rajan-SCS closed this Jan 18, 2022
@Rajan-SCS Rajan-SCS force-pushed the 15_mig_crm_operating_unit branch from 58f0a19 to aa36f70 Compare January 18, 2022 09:20
@Rajan-SCS Rajan-SCS reopened this Jan 18, 2022
@Rajan-SCS
Copy link
Contributor Author

@AaronHForgeFlow could you please check the PR

@Rajan-SCS Rajan-SCS force-pushed the 15_mig_crm_operating_unit branch from 3e4c59a to 5a61e10 Compare January 19, 2022 06:52
@nikul-serpentcs
Copy link
Member

@AaronHForgeFlow now ready to review

AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + Functional ok!

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-442-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 22, 2022
@OCA-git-bot
Merge PR #442 into 15.0
782c268 
Signed-off-by AaronHForgeFlow
@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-442-by-AaronHForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

JuanyDForgeflow
JuanyDForgeflow approved these changes May 12, 2022
View reviewed changes
Copy link

@JuanyDForgeflow JuanyDForgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review is OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-442-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 12, 2022
@OCA-git-bot
Merge PR #442 into 15.0
fc582b4 
Signed-off-by AaronHForgeFlow
@OCA-git-bot
Copy link
Contributor

@AaronHForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-442-by-AaronHForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow
Copy link
Contributor

Hi @Rajan-SCS , can you check if running pre-commit again is needed here?

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

SerpentCS and others added 24 commits January 10, 2023 12:15
@SerpentCS @OCA-git-bot
Added Copyrights in xml files and made minor changes.
f1c0260
@AaronHForgeFlow @OCA-git-bot
Style issues and change field position in view
3149b40
@AaronHForgeFlow @OCA-git-bot
added domain to see only OUs form that company.
999c1a1
@AaronHForgeFlow @OCA-git-bot
PEP8 issues
6f0520b
@pedrobaeza @OCA-git-bot
Make modules uninstallable
e15499a
@pedrobaeza @OCA-git-bot
Rename manifest files
5c8a11e
@LoisRForgeFlow @OCA-git-bot
crm_operating_unit to v10.0
e4125ba 
various fixes
@AdriaGForgeFlow @OCA-git-bot
Migrate crm_operating_unit to v12
8a02b1b
@oca-travis @OCA-git-bot
Update crm_operating_unit.pot
fcf9098
@OCA-git-bot
README.rst
183483c
@alan196 @OCA-git-bot
crm_operating_unit: black, isort
a723bf3
@alan196 @OCA-git-bot
crm_operating_unit: Migration to V13
e96bcc8
@oca-travis @OCA-git-bot
Update crm_operating_unit.pot
233ba31
@OCA-git-bot
README.rst
97e4bb8
@alan196 @OCA-git-bot
Added translation using Weblate (Spanish)
199ef49
@alan196 @OCA-git-bot
Added translation using Weblate (Spanish (Mexico))
2ca3800
@alan196 @OCA-git-bot
Translated using Weblate (Spanish (Mexico))
92467f5 
Currently translated at 100.0% (2 of 2 strings)

Translation: operating-unit-13.0/operating-unit-13.0-crm_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-crm_operating_unit/es_MX/
@OCA-git-bot
pre-commit update
5281b29
@MiquelRForgeFlow @OCA-git-bot
Eficent -> ForgeFlow
a555fa0
@OCA-git-bot
README.rst
7a286e7
@alan196 @OCA-git-bot
crm_operating_unit: black, isort, prettier
8e95070
@alan196 @OCA-git-bot
crm_operating_unit: Migration to 14.0
369dc22
@oca-travis @OCA-git-bot
Update crm_operating_unit.pot
d29bd2b
@Rajan-SCS @OCA-git-bot
[MIG] Migreted crm_operating_unit in v15
65f7920
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15_mig_crm_operating_unit branch from 5a61e10 to 65f7920 Compare January 10, 2023 12:15
@AaronHForgeFlow
Copy link
Contributor

Same here @Rajan-SCS pre-commit is failing, just let us know if you have time to fix it.

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Jan 13, 2023
Merged
@AaronHForgeFlow
Copy link
Contributor

Superseded here: #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikul-serpentcs nikul-serpentcs nikul-serpentcs left review comments

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@JuanyDForgeflow JuanyDForgeflow JuanyDForgeflow approved these changes

@BT-apadron BT-apadron BT-apadron approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.