Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][mig] pim: Migration to 16.0 #165

Closed
wants to merge 32 commits into from

Conversation

dsolanki-initos
Copy link

@dsolanki-initos dsolanki-initos commented Jul 20, 2023

This module depends on product_attribute_set #142 and product_attribute_set_completeness #164 .

clementmbr and others added 30 commits July 20, 2023 17:05
New organization :

- attribute_set (former base_custom_attribute)
- product_attribute_set (former pim_custom_attribute but without menus)
- pim (The "PIM application" former pim_base)
- pim_attrubute_set (depends on product_attribute_set and adds menus in
the PIM application)
attribute_set need 'include_native_attribute' param in context in order to work properly
Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration LGTM

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add test dependencies?

<?xml version="1.0" encoding="utf-8" ?>
<odoo>
<record id="module_category_pim" model="ir.module.category">
<field name="name">PIM</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I´d move this category and the base menu entry to a base_pim module so that it can be shared w/ all pim modules

@victorvermot
Copy link

@sbejaoui Could you attend to simahawk's comments on this one as well ? Ty in advance

@simahawk
Copy link
Contributor

@dsolanki-initos ping

@hspl-priva
Copy link

hspl-priva commented Jan 19, 2024

LGTM @dsolanki-initos @pedrobaeza tested. seems ok. i think we can merge this.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants