-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][mig] pim: Migration to 16.0 #165
Conversation
New organization : - attribute_set (former base_custom_attribute) - product_attribute_set (former pim_custom_attribute but without menus) - pim (The "PIM application" former pim_base) - pim_attrubute_set (depends on product_attribute_set and adds menus in the PIM application)
attribute_set need 'include_native_attribute' param in context in order to work properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add test dependencies?
<?xml version="1.0" encoding="utf-8" ?> | ||
<odoo> | ||
<record id="module_category_pim" model="ir.module.category"> | ||
<field name="name">PIM</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I´d move this category and the base menu entry to a base_pim module so that it can be shared w/ all pim modules
@sbejaoui Could you attend to simahawk's comments on this one as well ? Ty in advance |
@dsolanki-initos ping |
LGTM @dsolanki-initos @pedrobaeza tested. seems ok. i think we can merge this. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This module depends on
product_attribute_set
#142 andproduct_attribute_set_completeness
#164 .