Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging PR should mark a line in the "Migration to version xx" issue as done. #189

Closed
legalsylvain opened this issue Jun 15, 2022 · 2 comments · Fixed by #192
Closed

Merging PR should mark a line in the "Migration to version xx" issue as done. #189

legalsylvain opened this issue Jun 15, 2022 · 2 comments · Fixed by #192
Labels
enhancement New feature or request

Comments

@legalsylvain
Copy link
Collaborator

Ref : talk here with @pedrobaeza

Event : on pull_request / merged

Action :

  1. check in all the comments of the PR if one contains the order /ocabot migration yyy
  2. if yes, find the issue named "Migration to version xx"
  3. if found, find the line name "- [ ] yyy - By @xxx - PR ref"
  4. if found replace "- [ ]" by "- [x]"

Regarding step 1, I think it's going to be a little heavy to do that, but I don't see any alternative to identify the yyy (module name).

Comments welcome.

@legalsylvain legalsylvain added the enhancement New feature or request label Jun 15, 2022
@pedrobaeza
Copy link
Member

Instead of 1, I think it's better to just go to the migration issue of the target branch, and look for a line with the PR number. If found, mark it if not already done.

@legalsylvain
Copy link
Collaborator Author

Instead of 1, I think it's better to just go to the migration issue of the target branch, and look for a line with the PR number. If found, mark it if not already done.

💯 Indeed ! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants