[RFC] Content of Migration Issues and use of ocabot migration command

[legalsylvain]

hi all,

In each upgrade, openupgrade maintainers are creating an issue for the migration. like this one for the V14 #2190

Initialization of the migration Issue for 15

I just create an issue for migration 15 here : #3287

In my opinion, initializing the issue with the list of the all the odoo modules is redundant with the main file present here :
https://github.com/OCA/OpenUpgrade/blob/15.0/docsource/modules140-150.rst

So I'm in favour to have an empty issue and to a line per module with PR.

What do you think ?

use of ocabot command

Previously, maintainers has to update manually the issue to make reference to each PR. See :

I just made a test here and here and using the command \ocabot migration module_name works perfectly well.

Advantage :

• main migration issue is automatically updated when the PR is created
• migration PR receive the milestone 15.0
• merging PR update automatically the issue.

Do you agree that from now on we should use this command to update the main issue?

Thanks for your comment.

[pedrobaeza]

merging PR update automatically the issue.

This is not really true. Such feature is not developed (although very interesting of course, not only here).

OK for me to use the command.

About the list, I populate it manually. It's very easy with a text editor to make some replace to get what's needed from the RST.

[legalsylvain]

This is not really true. Such feature is not developed (although very interesting of course, not only here).

Oh ! IYou're right. Opened an issue : OCA/oca-github-bot#189

About the list, I populate it manually. It's very easy with a text editor to make some replace to get what's needed from the RST.

And what about to NOT pre-populate it ?

• the info is still in the main file modules140-150.rst. So a simple link at the beginning of the issue makes the job IMO.
• I fear that some extra text like |del| or > (for rename) break the current regular expression defined here to search the line.

[pedrobaeza]

OK for me.

[StefanRijnhart]

Mmm, maybe we can then reflect the list of open module migration PRs in modules140-150.rst as well!

[legalsylvain]

Mmm, maybe we can then reflect the list of open module migration PRs in modules140-150.rst as well!

I'm not sure. Indeed, having all the information in the same page (and available on the documentation is great). In the other hand I think it will add extra work for commiters. I mean :

for the time being, to propose a PR :

• make a branch / commit changes / make a PR

With your proposal :

• make a branch / commit changes / make a PR / Get the number of the github PR and set it in the modulesxxx.rst / commit & squach changes / Push PR again --force.

What do you think ? Did I missed something ?

[pedrobaeza]

Already done.