Test only supported Odoo versions #189

SirTakobi · 2023-03-23T15:00:16Z

Implementing what suggested in

The best bet is to modify the OCA CI to only use OCB. At the end, there won't be any counterpart, as there are no more Odoo updates, so if right now is green, the only chance to break it is on OCB. And we will gain less energy consumption in the builds.

Originally posted by @pedrobaeza in odoo/odoo#115782 (comment)

The issue fixed in the linked PR is blocking many good PRs in 12.0 out there.

Here I allow to choose if tests should be executed in Odoo/OCB.

I don't know how to test this locally so I just wrote what seemed appropriate, any feedback is appreciated.
I tried removing the old .copier-answers from a repository and copier /path/to/oca-addons-repo-template . but it isn't using the edited template that I have locally.

legalsylvain

The idea look great 👍 ! I'm always OK to reduce the impact of the CI when tests are unnecessary.

About the selection of the version, 13.0 is not a good choice for the time being (and maybe 12.0)
See :

last V10 commits : https://github.com/odoo/odoo/commits/10.0 : May 18, 2021. (~2 years ago, 🆗)
last V11 commits : https://github.com/odoo/odoo/commits/11.0 : Jan 20, 2022. (14 monthes ago, 🆗)
last V12 commits : https://github.com/odoo/odoo/commits/12.0 : Oct 13, 2022 (6 monthes ago, 👍 / 👎 )
last V13 commits : https://github.com/odoo/odoo/commits/13.0 : Mar 13, 2023 (~10 days ago, totally 🚫 )

as a safe choice, I would therefore propose the following rule:
We can remove the odoo "X.0" branch from the OCA CI, and use only OCB if there is no commit on the "X.0" branch for one year.

So for the time being : 10.0 and 11.0. (and remove 12.0 in October 2023, if no new commits are pushed).

What do you think ?

src/.github/workflows/{% if ci == 'GitHub' %}test.yml{% endif %}.jinja

SirTakobi · 2023-03-23T15:50:19Z

Thanks for having a look!

The idea look great 👍 ! I'm always OK to reduce the impact of the CI when tests are unnecessary.

About the selection of the version, 13.0 is not a good choice for the time being (and maybe 12.0) See :

last V10 commits : https://github.com/odoo/odoo/commits/10.0 : May 18, 2021. (~2 years ago, 🆗)

last V11 commits : https://github.com/odoo/odoo/commits/11.0 : Jan 20, 2022. (14 monthes ago, 🆗)

last V12 commits : https://github.com/odoo/odoo/commits/12.0 : Oct 13, 2022 (6 monthes ago, 👍 / 👎 )

last V13 commits : https://github.com/odoo/odoo/commits/13.0 : Mar 13, 2023 (~10 days ago, totally 🚫 )

as a safe choice, I would therefore propose the following rule: We can remove the odoo "X.0" branch from the OCA CI, and use only OCB if there is no commit on the "X.0" branch for one year.

So for the time being : 10.0 and 11.0. (and remove 12.0 in October 2023, if no new commits are pushed).

What do you think ?

I have restored 13.0 because:

looks like it is still updated: other than the last commit, there is roughly one commit every ~10 days
I am actually not aware of any issue in that version.

I would keep excluding 12.0 because:

right now it is failing;
being the last update 6 months ago, I have some doubts it will ever be fixed;
last but not least, I am still using it 😄, so in order to contribute to OCA I need the CI to be working.

legalsylvain

for me makes sense. But I'm not expert of that repo, so other review are welcome.

thanks for the changes !

yajo

LGTM. @sbidoul can you please confirm that the makepot change should behave as expected?

sbidoul · 2023-03-24T18:13:06Z

I think it would be more flexible to add a copier question to enable odoo and/or ocb tests.
This way the odoo test can be disabled by default on older branches but people can still enable them if they want to.

SirTakobi · 2023-03-27T07:08:47Z

I think it would be more flexible to add a copier question to enable odoo and/or ocb tests. This way the odoo test can be disabled by default on older branches but people can still enable them if they want to.

Good idea, that would be more flexible for sure, I should look up how to do that.
But other than possible technical problems, how should the question behave?

Choose Odoo/OCB for all versions?
Maybe is too extreme
Or choose Odoo/OCB for each version?
Dynamic number of questions: is that even possible?
Or something in between?
Maybe we ask only for specific versions, like the ones I am already excluding here

sbidoul · 2023-03-27T07:52:26Z

I think we can have a question such as "Which Odoo flavor to test?" with 3 possible answers: odoo/OCB/both.

SirTakobi · 2023-03-27T08:13:22Z

I think we can have a question such as "Which Odoo flavor to test?" with 3 possible answers: odoo/OCB/both.

Right, I forgot that each template is used only for one version at a time 😅 ok then I'll look up how to use the questions to do this.

bealdav · 2023-03-27T08:53:26Z

Good initiative here.

SirTakobi · 2023-03-27T12:12:49Z

🤔 sorry for the multiple review requests, apparently I can't re-request review from both @yajo and @legalsylvain.

Anyway, I re-requested the reviews because something changed: now the user can choose what to enable, let me know what you think 😄
cc @sbidoul

sbidoul · 2023-03-27T12:16:35Z

@SirTakobi does it enable makepot in case OCB only is selected?

SirTakobi · 2023-03-27T12:21:16Z

@SirTakobi does it enable makepot in case OCB only is selected?

Yes because makepot is added to the last configuration, regardless of what was selected

sbidoul · 2023-03-27T13:41:21Z

@SirTakobi we must ensure to not run makepot twice. So it should appear in OCB jobs only it the flavor is OCB.

SirTakobi · 2023-03-27T14:36:57Z

@SirTakobi we must ensure to not run makepot twice. So it should appear in OCB jobs only it the flavor is OCB.

Looking at the code changes, I think it will only be run once; of the three possible choices:

"Odoo": makepot is run in "Odoo"
"OCB": makepot is run in "OCB"
"Both": makepot is run in "OCB"

Have you noticed some case in the code that I'm missing?

sbidoul · 2023-03-27T14:46:06Z

Ah, yes, sorry I misunderstood. 👍

sbidoul · 2023-03-27T14:46:11Z

Ah, yes, sorry I misunderstood. 👍

yajo · 2023-03-28T08:07:01Z

Thanks!

Would you please apply this into one or two repos before we do a release? So we can see it works in the real world. Update to latest unreleased change with:

copier -r HEAD update

SirTakobi · 2023-03-28T09:16:12Z

Thanks!

Would you please apply this into one or two repos before we do a release? So we can see it works in the real world. Update to latest unreleased change with:
copier -r HEAD update

Done in OCA/l10n-italy#3241

sbidoul · 2023-03-28T09:23:25Z

copier.yml

@@ -76,6 +76,15 @@ ci:
    - GitHub
  help: Which CI system to use ?

+odoo_test_flavor:
+  type: str
+  default: Both


Do we want to set the default value to OCB for Odoo < 13 ?

Yes that might be useful

but honestly I don't know how to do that, is that even possible? I mean, this is not a jinja template

We already have default: "https://github.com/{{ org_slug }}/{{ repo_slug }}" so we probably can put any python expression in there?

Yes, you can do that.

SirTakobi · 2023-03-28T09:33:47Z

Yes that might be useful

…

On Tue, Mar 28, 2023 at 11:23 AM Stéphane Bidoul ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In copier.yml <#189 (comment)> : > @@ -76,6 +76,15 @@ ci: - GitHub help: Which CI system to use ? +odoo_test_flavor: + type: str + default: Both Do we want to set the default value to OCB for Odoo < 13 ? — Reply to this email directly, view it on GitHub <#189 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYHLQYGSE3LRMHAE257GCQDW6KUZXANCNFSM6AAAAAAWFKKRPQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

SirTakobi marked this pull request as ready for review March 23, 2023 15:04

legalsylvain suggested changes Mar 23, 2023

View reviewed changes

SirTakobi force-pushed the unsupported_odoo_versions branch from 047327e to 53d481f Compare March 23, 2023 15:39

legalsylvain reviewed Mar 23, 2023

View reviewed changes

src/.github/workflows/{% if ci == 'GitHub' %}test.yml{% endif %}.jinja Outdated Show resolved Hide resolved

SirTakobi force-pushed the unsupported_odoo_versions branch from 53d481f to f8d770c Compare March 23, 2023 15:53

SirTakobi requested a review from legalsylvain March 23, 2023 15:55

legalsylvain approved these changes Mar 23, 2023

View reviewed changes

yajo approved these changes Mar 24, 2023

View reviewed changes

OCA-git-bot added the approved label Mar 24, 2023

SirTakobi marked this pull request as draft March 27, 2023 08:13

SirTakobi force-pushed the unsupported_odoo_versions branch from f8d770c to a54d5da Compare March 27, 2023 11:54

SirTakobi marked this pull request as ready for review March 27, 2023 12:09

SirTakobi requested review from yajo and legalsylvain and removed request for yajo and legalsylvain March 27, 2023 12:09

Allow to choose Odoo Flavor

aeb59b9

SirTakobi force-pushed the unsupported_odoo_versions branch from 0934527 to aeb59b9 Compare March 27, 2023 13:32

sbidoul approved these changes Mar 27, 2023

View reviewed changes

yajo approved these changes Mar 28, 2023

View reviewed changes

yajo merged commit ff96cae into OCA:master Mar 28, 2023

SirTakobi mentioned this pull request Mar 28, 2023

Updated from template OCA/l10n-italy#3241

Merged

sbidoul reviewed Mar 28, 2023

View reviewed changes

SirTakobi mentioned this pull request Mar 28, 2023

Default Flavor #191

Merged

AungKoKoLin1997 mentioned this pull request Apr 14, 2023

[UPD] dotfiles qrtl/hls-custom#207

Merged

This was referenced May 16, 2023

Add Copier OCA/website#958

Merged

Updated from template OCA/social#1147

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test only supported Odoo versions #189

Test only supported Odoo versions #189

SirTakobi commented Mar 23, 2023 •

edited

Loading

legalsylvain left a comment

SirTakobi commented Mar 23, 2023

legalsylvain left a comment

yajo left a comment

sbidoul commented Mar 24, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

bealdav commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

sbidoul commented Mar 27, 2023

yajo commented Mar 28, 2023

SirTakobi commented Mar 28, 2023

sbidoul Mar 28, 2023

SirTakobi Mar 28, 2023

sbidoul Mar 28, 2023

yajo Apr 10, 2023

SirTakobi commented Mar 28, 2023 via email

Test only supported Odoo versions #189

Test only supported Odoo versions #189

Conversation

SirTakobi commented Mar 23, 2023 • edited Loading

legalsylvain left a comment

Choose a reason for hiding this comment

SirTakobi commented Mar 23, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

yajo left a comment

Choose a reason for hiding this comment

sbidoul commented Mar 24, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

bealdav commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

SirTakobi commented Mar 27, 2023

sbidoul commented Mar 27, 2023

sbidoul commented Mar 27, 2023

yajo commented Mar 28, 2023

SirTakobi commented Mar 28, 2023

sbidoul Mar 28, 2023

Choose a reason for hiding this comment

SirTakobi Mar 28, 2023

Choose a reason for hiding this comment

sbidoul Mar 28, 2023

Choose a reason for hiding this comment

yajo Apr 10, 2023

Choose a reason for hiding this comment

SirTakobi commented Mar 28, 2023 via email

SirTakobi commented Mar 23, 2023 •

edited

Loading