[16.0][MIG] purchase sale inter company: Migration to 16.0 #430
Conversation
chafique-delli
force-pushed
the
16.0-mig-purchase_sale_inter_company
branch
2 times, most recently
from
e47ddb6 to
c0a5ad9
Compare
chafique-delli
force-pushed
the
16.0-mig-purchase_sale_inter_company
branch
from
c0a5ad9 to
94d29c0
Compare
chafique-delli
force-pushed
the
16.0-mig-purchase_sale_inter_company
branch
from
94d29c0 to
0df6789
Compare
chafique-delli
force-pushed
the
16.0-mig-purchase_sale_inter_company
branch
2 times, most recently
from
665553c to
d455a7b
Compare
… and auto_purchase_line_id field in sale_order_line
…d purchase_order_view.xml
…price in purchase line when validating the sale order
… order to load it with the correct context
This is the splitted module from original to remove dependency on stock
Pricelist currency should be same with PO/SO document If corresponding pricelist currency is not the same find or create propriate pricelist
Company contacts can be Vendors to create SO from PO
If purchase_exception or sale_exception modules are installed we have an issue in tests, because order's confirm methods won't be called. Possible fix is to set ignore_exception=True on orders in tests. Exception check could be skipped by setting check_exception=False, as mentioned in base_exception, but in fact it doesn't work.
Pricelist is set with the company
Update v14 latest changes related to test case failing
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-15.0/multi-company-15.0-purchase_sale_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-15-0/multi-company-15-0-purchase_sale_inter_company/
chafique-delli
force-pushed
the
16.0-mig-purchase_sale_inter_company
branch
from
d455a7b to
07a10bb
Compare
|
@sebastienbeau , can you review, please ? |
|
I think the issue of this module is, need to be in one branch with sale_purchase_inter_company, so that testing of all function can be covered. CMIIW |
|
Hi @chafique-delli, it looks like it has been superseded in #513 |
|
Yes, that's is, sorry. As you didn't put the module name correctly in the PR title, a search over the open pull request didn't return this one. Closing. Please feel free to review the merged one and add any comment. |
@pedrobaeza , I was unpleasantly surprised to see that another PR created recently for the same module was merged immediately. While my PR was awaiting reviews. |
|
As said, we search for existing migration, but yours didn't appear due to the incorrect PR title, and thus, we proceed with our usual flow: do the migration, and review ourselves (but doing it properly, not only "approving" it), without waiting for spontaneous reviewers. You can adopt such flow in your company, which is healthier, and also scale in PSC/maintainer roles for being able to mark the module in the migration issue, or merge the PR. |
cc @sebastienbeau , @Kev-Roche