Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_es_facturae_face: Use Prod for testing #3411

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[16.0][FIX] l10n_es_facturae_face: Use Prod for testing #3411

merged 3 commits into from
Jan 31, 2024

Conversation

etobella
Copy link
Member

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 30, 2024
@etobella etobella changed the title [16.0][FIX] l10n_es_facturae_face: Use Prod for testing @etobella [16.0][FIX] l10n_es_facturae_face: Use Prod for testing Jan 30, 2024
@etobella
Copy link
Member Author

Para hacer que funcionase todo, he puesto la misma versión del cryptography que bloquea odoo

Por otro lado, he tirado hacia atrás el commit de #3401 ya que el error que daba originalmente se debía a que estan cambiando todo el webservice, cosa que me parece correcto. Así que, IMO, es mejor dejar el código original, ya que realizó sus funciones a la perfección.

@pedrobaeza
Copy link
Member

Es mejor juntar todos los commits de pin en uno solo (y de hecho, el requirements.txt debe cambiarse solo con pre-commit), comentando la razón para hacer ese pinning como texto del mismo.

@etobella
[FIX] l10n_es_aeat,l10n_es_facturae,l10n_es_facturae_face: pin crypto…
ea23d96 
…grahy library version

We want to avoid the installation of newer versions that might be incompatible with odoo
@etobella
Copy link
Member Author

Hecho!

pedrobaeza
pedrobaeza approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3411-by-pedrobaeza-bump-patch, awaiting test results.

@pedrobaeza pedrobaeza mentioned this pull request Jan 31, 2024
Merged
@OCA-git-bot OCA-git-bot merged commit 8afad87 into OCA:16.0 Jan 31, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a741d25. Thanks a lot for contributing to OCA. ❤️

@yajo
Copy link
Member

yajo commented Jan 2, 2025

Al fusionarse odoo/odoo#169136, este PR hace el módulo incompatible con python 3.12.

@etobella
Copy link
Member Author

etobella commented Jan 2, 2025

@yajo no creo que un PR cerrado hace un año sea el lugar para dejarte este comenetario (un issue me parece más apropiado). Además, faltaria saber por que falla...

@yajo
Copy link
Member

yajo commented Jan 2, 2025

Pongo el comentario por si alguien más acaba aterrizando aquí buscando el por qué de un fallo de dependencias. El fix sería poner estas dependencias en el manifest del módulo, o no usar python 3.12.

De nada.

@etobella
Copy link
Member Author

etobella commented Jan 2, 2025

@yajo Tienendo en cuenta que ya tienes la solución, no seria más fácil añadir el fix en el módulo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@etobella @pedrobaeza @OCA-git-bot @yajo