Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] l10n_es_intrastat_report #2136

Merged
merged 28 commits into from
Oct 20, 2022
Merged

[15.0][MIG] l10n_es_intrastat_report #2136

merged 28 commits into from
Oct 20, 2022

Conversation

flachica
Copy link
Contributor

@flachica flachica commented Feb 18, 2022 •
edited
Loading

@oca-clabot
Copy link

Hey @flachica, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@flachica flachica mentioned this pull request Feb 18, 2022
Closed
48 tasks
@HaraldPanten
Copy link
Contributor

@flachica Si puedes ve haciendo revisiones en las dependencias. Que eso siempre acelera el proceso 👍

@flachica
Copy link
Contributor Author

@flachica Si puedes ve haciendo revisiones en las dependencias. Que eso siempre acelera el proceso 👍

Si, está claro. Es el próximo paso. Tengo que dar con la tecla pues cuando reviso me salen demasiados cambios y no consigo tener claro lo que hizo exactamente quien migró cada dependencia

@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch 2 times, most recently from 129be8a to 245f187 Compare February 20, 2022 09:44
@flachica
Copy link
Contributor Author

Revisiones hechas. Para ver las modificaciones que se realizan respecto al código original es sencillo. Vamos del PR a la rama que lo genera, luego en la parte superior derecha buscamos la palabra Contribute y hacemos click en Open Pull Request. Esto nos ofrece la comparativa que estaba buscando.

@flachica
Copy link
Contributor Author

Hey @flachica, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

He modificado el commit afectado por mi error

@victoralmau
Copy link
Member

victoralmau commented Feb 23, 2022 •
edited
Loading

Gracias por la aportación.
Será necesario incluir los cambios relativos en #2133 y #2148 en el histórico de commits antes de los propios de migración.

@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch 2 times, most recently from f01d376 to f3868ac Compare February 23, 2022 17:52
@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch 2 times, most recently from 18918cb to ff9d28c Compare February 23, 2022 20:49
@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch from ff9d28c to 6a4ed20 Compare May 25, 2022 09:41
@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch from 6a4ed20 to 3960a3c Compare August 17, 2022 10:42
@victoralmau
Copy link
Member

Ahora que ya están todas las dependencias fusionadas, puedes hacer rebase y así poder revisarlo?

Faltará por añadir cambios de 14 en el historial de commits: cb6b2b6 + #2403

@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch from 3960a3c to 3d912a9 Compare October 11, 2022 15:39
@flachica
Copy link
Contributor Author

Falla algo de ticket bai. Mañana le echaré un ojo con más atención

@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch 3 times, most recently from 529cd7b to 909144d Compare October 18, 2022 08:08
@flachica
Copy link
Contributor Author

Me está costando resolver los problemas con los tests. Contexto:

  • El módulo l10n_es_intrastat_report necesita de un plan contable genérico. Le he incluido la dependencia a l10n_generic_coa
  • Al ejecutar los tests me dice que le ponga el tag post_install.
  • Cuando hago ese cambio en los tests no los pasa. Supongo que es porque fallan los de Ticketbai previamente pues no hay rastro de que se ejecute ningún test de la clase TestL10nIntraStatReport. Busco en el log esa cadena y no la encuentro.

Así que necesito un poquito de luz

@pedrobaeza
Copy link
Member

No debes poner esa dependencia. Pon lo del post_install, eso sí.

@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch from 909144d to 1608d45 Compare October 18, 2022 08:48
@flachica
Copy link
Contributor Author

@victoralmau Ya pasan los tests

@pedrobaeza
Copy link
Member

/ocabot migration l10n_es_intrastat_report

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 18, 2022
@pedrobaeza
Copy link
Member

¿Podrías traerte también f88d7f9 ?

OCA-git-bot and others added 11 commits October 19, 2022 11:40
@OCA-git-bot @flachica
l10n_es_intrastat_report 14.0.1.1.0
3b53a28
@ValentinVinagre @pedrobaeza @flachica
[IMP] l10n_es_intrastat_report: adaptacion para la nueva presentacion…
3d6a795 
… de 2022

Co-Authored-By: Pedro M. Baeza <[email protected]>
@victoralmau @flachica
[FIX] l10n_es_intrastat_report: Change the link to the codes.
7e173d7 
TT34295
@OCA-git-bot @flachica
l10n_es_intrastat_report 14.0.2.0.1
cb7ba8d
@victoralmau @flachica
[IMP] l10n_es_intrastat_report: Add to notes when missing partner_vat…
dd7f75b 
… and show error when missing product_origin_country_id in line.

TT29332
@OCA-git-bot @flachica
l10n_es_intrastat_report 14.0.2.1.0
1eba623
@pedrobaeza @flachica
[FIX] l10n_es_intrastat_report: Test at post-install
3e0a7c7 
Since 81aac30dd2278e43a43cf8fd6cef31e1e8c60f3f, all tests depending on
invoicing base test should be post-install.
@victoralmau @flachica
[FIX] l10n_es_intrastat_report: Change the link to the codes.
1d600d7 
TT34295
@victoralmau @flachica
[IMP] l10n_es_intrastat_report: Add to notes when missing partner_vat…
32b762a 
… and show error when missing product_origin_country_id in line.

TT29332
@pedrobaeza @flachica
[FIX] l10n_es_intrastat_report: Test at post-install
47ac514 
Since 81aac30dd2278e43a43cf8fd6cef31e1e8c60f3f, all tests depending on
invoicing base test should be post-install.
@pedrobaeza @flachica
[IMP] l10n_es_intrastat_report: 2022 NC codes
53d62cb 
Updated from https://sede.agenciatributaria.gob.es/Sede/estadisticas/estadisticas-comercio-exterior/nomenclatura-combinada-ano.html

TT35871
@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch from 1608d45 to a6968b2 Compare October 19, 2022 09:41
victoralmau
victoralmau reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, creo que el commit f88d7f9 no era necesario añadirlo aquí porque hace referencia a otro módulo diferente.

Por lo demás, en un principio estaría todo correcto.

@pedrobaeza
Copy link
Member

Perdón, error garrafal mío...

@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch from a6968b2 to 9fdad6b Compare October 19, 2022 09:58
@flachica
Copy link
Contributor Author

He rebasado la rama y los tests fallarán por algo de los .js (supongo por no haberlos renombrado a esm.js) del módulo pos de ticketbai

@flachica
Copy link
Contributor Author

Disculpad, el pre-commit ha sabido resolverlo. En local me estaba dando problemas pero parece que runboat lo interpreta correctamente

@flachica flachica force-pushed the 15.0-mig-l10n_es_intrastat_report branch from 9fdad6b to c7fd0da Compare October 20, 2022 06:28
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2136-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 79b906f into OCA:15.0 Oct 20, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 70ac04e. Thanks a lot for contributing to OCA. ❤️

@flachica flachica deleted the 15.0-mig-l10n_es_intrastat_report branch October 20, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@victoralmau victoralmau victoralmau approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.