Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0] fix send importe total IRPF #1508

Merged
merged 4 commits into from
Nov 16, 2020
Merged

[11.0] fix send importe total IRPF #1508

merged 4 commits into from
Nov 16, 2020

Conversation

RodrigoBM
Copy link
Contributor

Buenas,

He añadido los cambios #1409 y #1414 realizados en la V12 y los he pasado a la V11.

Un saludo

JuanjoA and others added 3 commits November 16, 2020 10:38
@JuanjoA @RodrigoBM
Extract method to obtain if an invoice should be simplified or not
2874832
@JuanjoA @RodrigoBM
[FIX] l10n_es_aeat_sii: Envío al SII ImporteTotal sin IRPF en factura…
c21bc5b 
…s de proveedor

- Añadido aeat.sii.map.lines para NotIncludedInTotal
- facturas emitidas irpf
@pedrobaeza @RodrigoBM
[FIX+IMP] l10n_es_aeat_sii: Adjust "total without IRPF" algorithm
7a00bfb 
- Don't process again everything, but do it inline on existing methods
- Make tests resilient
@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

HaraldPanten
HaraldPanten approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En principio, a mí me encaja.

HaraldPanten
HaraldPanten requested changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooopps, espera que falla travis

@RodrigoBM
Copy link
Contributor Author

Si, lo reviso

@RodrigoBM
Copy link
Contributor Author

Corregido, se me ha pasado quitar to_date que es la nueva función en V12 en vez de utilizar from_string que es la que le corresponde en V11

@RodrigoBM
Copy link
Contributor Author

Buenas, @HaraldPanten ya ha pasado Travis

HaraldPanten
HaraldPanten approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siguiendo la lógica de los [FIX] para V12 debería estar bien.

@pedrobaeza ?

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 11.0-ocabot-merge-pr-1508-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 32cbebd into OCA:11.0 Nov 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d76e381. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 11.0-fix-send-ImporteTotal-IRPF branch November 16, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees

@pedrobaeza pedrobaeza

Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RodrigoBM @OCA-git-bot @pedrobaeza @HaraldPanten @JuanjoA