[FIX] l10n_it_riba: remove account and journal domain #4455
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
SirAionTech
added
the
is porting
odooNextev
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Review tecnica e funzionale OK per il porting.
PS. Cambierei solo il titolo della PR perchè ero partito con l'idea di togliere le restrizioni del dominio anche per il registro di banca, ma poi non l'ho fatto e non ricordo di preciso il motivo.
Allora non l'ho cambiato, ma visto che questa è ancora aperta si può fare.
Funzionalmente invece lasciando la forzatura di un conto di tipo banca, la PR va bene se l’insoluto viene accreditato e poi stornato dalla banca altrimenti anche il registro dovrebbe essere libero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.