Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] l10n_it_account_stamp: Usabilità per il bollo in fattura #3802

Merged

Conversation

SirAionTech
Copy link
Contributor

@SirAionTech SirAionTech commented Dec 27, 2023

Risolve #2447 per 16.0.

Forward port di #2448.
Manca c34b359 perché è stato risolto nella migrazione 86e6cc7.

Sostituisce #3457 per risolvere #3457 (review).

@SirAionTech

This comment was marked as resolved.

@SirAionTech SirAionTech force-pushed the 16.0-imp-l10n_it_account_stamp-usability branch from 6c28e09 to c9f5439 Compare December 27, 2023 15:03
@SirAionTech SirAionTech marked this pull request as ready for review December 27, 2023 15:20
@SirAionTech SirAionTech force-pushed the 16.0-imp-l10n_it_account_stamp-usability branch from c9f5439 to bb1acaa Compare January 26, 2024 10:26
@SirAionTech SirAionTech force-pushed the 16.0-imp-l10n_it_account_stamp-usability branch from bb1acaa to f49666f Compare March 6, 2024 16:43
@SirAionTech
Copy link
Contributor Author

Fatto rebase per risolvere i conflitti

If stamp line can be added (invoice in draft): show button to add stamp line.
If stamp line can't be added (invoice not in draft): show message explaining why it can't be added.
If stamp line has already been added: show message saying it has already been added (useful if invoice has many lines).
Button and messages update live while updating the invoice.
Better messages to user for charging stamp to customer

Co-authored-by:  Simone Rubino <[email protected]>
@SirAionTech SirAionTech force-pushed the 16.0-imp-l10n_it_account_stamp-usability branch from f49666f to af82932 Compare June 3, 2024 07:36
@SirAionTech
Copy link
Contributor Author

Fatto rebase per riattivare runboat

Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiocorato
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3802-by-sergiocorato-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 278de92 into OCA:16.0 Jul 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 666efe9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMP] l10n_it_account_stamp: Usabilità per il bollo in fattura
5 participants