Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG][l10n_br_fiscal] #2805

Merged
merged 1,754 commits into from
Feb 2, 2024
Merged

[16.0][MIG][l10n_br_fiscal] #2805

merged 1,754 commits into from
Feb 2, 2024

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Nov 26, 2023 •
edited
Loading

Standard migration from the 15.0 migration (using #2803 as the basis)

Work in progress...

@rvalyi rvalyi force-pushed the 16.0-mig-l10n_br_fiscal branch from 8aa795e to c3a5f24 Compare November 26, 2023 19:42
@rvalyi rvalyi marked this pull request as draft November 26, 2023 19:49
@rvalyi rvalyi force-pushed the 16.0-mig-l10n_br_fiscal branch 7 times, most recently from 10fe64b to 2c9f1c2 Compare November 28, 2023 04:21
@rvalyi
Copy link
Member Author

rvalyi commented Nov 28, 2023

/ocabot migration l10n_br_fiscal

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 28, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 28, 2023
Open
61 tasks
@rvalyi rvalyi force-pushed the 16.0-mig-l10n_br_fiscal branch from 2c9f1c2 to 47ca021 Compare November 29, 2023 04:20
@rvalyi rvalyi marked this pull request as ready for review November 29, 2023 04:23
rvalyi and others added 16 commits December 10, 2023 02:50
@rvalyi
[REF] modern super() calls
75f2e0c
@rvalyi
[REF] create_multi support
a9441d0
@rvalyi
[REF] create_multi support
a5f2be3
@marcelsavegnago @rvalyi
[IMP] l10n_br_fiscal: changes the create method decorator (l10n_br_fi…
9ddd25e 
…scal.document )
@OCA-git-bot @rvalyi
l10n_br_fiscal 14.0.10.2.0
b8e9140
@marcelsavegnago @rvalyi
[IMP] l10n_br_fiscal: change the edoc state to authorized when the is…
4a3fcb0 
…suer is a partner
@marcelsavegnago @rvalyi
[IMP] l10n_br_fiscal: change the edoc state to in typing when the iss…
9fbe757 
…uer is a partner and account move back to draft
@marcelsavegnago @rvalyi
[IMP] l10n_br_fiscal: change the edoc state to cancel when the issuer…
6f31d97 
… is a partner and account move is cancel
@marcelsavegnago @rvalyi
[IMP] l10n_br_fiscal: add purchase document demo
70b8d07
@marcelsavegnago @rvalyi
[IMP] l10n_br_fiscal: add purchase document test state
1013738
@OCA-git-bot @rvalyi
l10n_br_fiscal 14.0.10.3.0
cd5fe66
@marcelsavegnago @rvalyi
[FIX] l10n_br_fiscal: fix l10n_br_fiscal.comment _name_search method
2bf99f4
@OCA-git-bot @rvalyi
l10n_br_fiscal 14.0.10.3.1
c1532f0
@augustodinizl @rvalyi
Translated using Weblate (Portuguese (Brazil))
76716ac 
Currently translated at 96.4% (1308 of 1356 strings)

Translation: l10n-brazil-14.0/l10n-brazil-14.0-l10n_br_fiscal
Translate-URL: https://translation.odoo-community.org/projects/l10n-brazil-14-0/l10n-brazil-14-0-l10n_br_fiscal/pt_BR/
@renatonlima @rvalyi
[FIX] l10n_br_fiscal: adapt ChaveEdoc method
9ae88c2
@OCA-git-bot @rvalyi
l10n_br_fiscal 14.0.10.3.2
02881d4
@rvalyi
Copy link
Member Author

rvalyi commented Feb 1, 2024

@douglascstd o problema na tela do regulamento do ICMS foi corrigido pelo @renatonlima . E ai OK pro merge?

@douglascstd
Copy link
Member

Ao tentar fazer o teste no runboat, nenhum módulo estava instalado (até tentei instalar, mas não segui uma sequencia)

Não foi possível validar a questão do menu:
image

@rvalyi
Copy link
Member Author

rvalyi commented Feb 1, 2024 •
edited
Loading

Ao tentar fazer o teste no runboat, nenhum módulo estava instalado (até tentei instalar, mas não segui uma sequencia)

Não foi possível validar a questão do menu: image

o @renatonlima acabou de quebrar os testes no ultimo commit uns minutos atras. @renatonlima ta ligado no problema?

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Feb 2, 2024 •
edited
Loading

acho que o erro está aqui

<field name="tax_id" ref="l10n_br_fiscal.tax_icms_20_50" />

pelo que vi até agora, falta ele aqui

image

@rvalyi
Copy link
Member Author

rvalyi commented Feb 2, 2024

acho que o erro está aqui

<field name="tax_id" ref="l10n_br_fiscal.tax_icms_20_50" />

Falei com o @renatonlima ontem. Ele quis atualizar as aliquotas para 2024 tb. mas no final das contas vai jogar esse commit num outro PR da 14.0 primeiro e tirar daqui.

@marcelsavegnago
Copy link
Member

aqui tbm

ValueError: External ID not found in the system: l10n_br_fiscal.tax_icms_22

@renatonlima renatonlima force-pushed the 16.0-mig-l10n_br_fiscal branch from ce5f4fe to af9bc18 Compare February 2, 2024 15:38
@renatonlima
Copy link
Member

Pessoal,

Eu removi o commit das atualizações das alíquotas eu vou fazer o PR na 14.0 e depois fazer o PR na 16.0 depois da migração

douglascstd
douglascstd approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@douglascstd douglascstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] FUNCIONAL REVIEW

Testes realizados nos comentários desta PR.

marcelsavegnago
marcelsavegnago approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boraaaa 🥳

@renatonlima
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2805-by-renatonlima-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2d54956 into OCA:16.0 Feb 2, 2024
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e625d91. Thanks a lot for contributing to OCA. ❤️

@renatonlima
Copy link
Member

Sextou @marcelsavegnago 🥳

@rvalyi rvalyi deleted the 16.0-mig-l10n_br_fiscal branch February 3, 2024 01:29
@mileo
Copy link
Member

mileo commented Feb 3, 2024

boa!

@marcelsavegnago marcelsavegnago mentioned this pull request Feb 8, 2024
Merged
@rvalyi rvalyi mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglascstd douglascstd douglascstd approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@renatonlima renatonlima renatonlima approved these changes

@antoniospneto antoniospneto Awaiting requested review from antoniospneto

@felipemotter felipemotter Awaiting requested review from felipemotter

@mileo mileo Awaiting requested review from mileo

Assignees
No one assigned
Labels
16.0 approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.