Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] github_connector: Migration to v12 #33

Merged
merged 22 commits into from
Feb 15, 2019
Merged

[12.0][MIG] github_connector: Migration to v12 #33

merged 22 commits into from
Feb 15, 2019

Conversation

cristinamartinrod
Copy link
Member

@oca-clabot
Copy link

Hey @cristinamartinrod, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 11, 2019
@pedrobaeza
Copy link
Member

Please squash some commits by logical set/author

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 11, 2019
Closed
3 tasks
@cristinamartinrod cristinamartinrod force-pushed the 12.0-mig-github_connector branch 2 times, most recently from f39c8da to 1831edf Compare January 12, 2019 10:31
Roel Adriaans and others added 11 commits January 12, 2019 11:44
@cristinamartinrod
[FIX] Fix syncing of members. The get_by_url method needs a fetch met…
ab3c1c3 
…hod.

[FIX] Add the organization_id.github_login to the github url

Making the github url the form: https://github.com/OCA/account-analytic/tree/9.0
and not the https://github.com/account-analytic/tree/9.0 before this commit

[IMP] Make travis happy

[IMP] Fix error with teams sync

We already have the organization in the team data,
and github does not provide anymore in the result for the
team data.
@legalsylvain @cristinamartinrod
[FIX] incorrect call to __super_
3387151 
[FIX] add ondelete cascade
[FIX] team creation from odoo
[FIX] possibility to recursively load an existing object
@zeroheure @cristinamartinrod
Typos (double "you" and comma)
4556594 
[REF] github_connector: Fix typo "should not => does not" (OCA#6)
@cubells @cristinamartinrod
[MIG] github_connector: Migration to 11.0
41c8e53 
[FIX] github_connector: remove duplicated group
@st-aprajapati @cristinamartinrod
Fixed issue while fetching organization, user and members in v11
99558a4 
* Fixed JSON response parsing issue while fetching data by URL
@pedrobaeza @cristinamartinrod
[IMP] github_connector: Add brand new icon and menu icon
53ced90
@sbidoul @cristinamartinrod
Trivial python3 fix
d0c6f1f
@StephanRozendaal @cristinamartinrod
[IMP] Add try-except on branch analyze action (OCA#26)
c03b094 
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
@sbidoul @cristinamartinrod
[FIX] logging interpolation
879b2da 
To play nice with Sentry.
@legalsylvain @cristinamartinrod
[FIX] remove obsolete markdown requirement
886ba50 
[IMP] robustness courtesy @astirpe

[FIX] warning message, courtesy @lasley and @astirpe

[FIX] typo

[UPD] add V11 serie in demo data

[FIX] various

typo

[REF] rename milestone into serie courtesy @sbidoul
@sbidoul @cristinamartinrod
[IMP] log error in case of multiple partners with same github id
b75b4cc 
[IMP] raise error instead of logging in case of duplicates

To avoid creating additional duplicates.
@cristinamartinrod cristinamartinrod force-pushed the 12.0-mig-github_connector branch from 1831edf to 1968d16 Compare January 12, 2019 10:45
cubells
cubells suggested changes Jan 14, 2019
View reviewed changes
github_connector/views/view_github_organization.xml Outdated Show resolved Hide resolved
github_connector/views/view_github_team_partner.xml Outdated Show resolved Hide resolved
github_connector/views/view_github_team_partner.xml Outdated Show resolved Hide resolved
github_connector/views/view_github_repository_branch.xml Outdated Show resolved Hide resolved
github_connector/models/abstract_github_model.py Show resolved Hide resolved
github_connector/wizards/wizard_update_branch_list.py Show resolved Hide resolved
github_connector/wizards/wizard_update_from_github.py Show resolved Hide resolved
github_connector/wizards/wizard_download_analyze_branch.py Show resolved Hide resolved
github_connector/wizards/wizard_create_team.py Outdated Show resolved Hide resolved
github_connector/wizards/wizard_create_team.py Outdated Show resolved Hide resolved
@cristinamartinrod cristinamartinrod force-pushed the 12.0-mig-github_connector branch from 1968d16 to d32c165 Compare January 22, 2019 16:27
@cristinamartinrod cristinamartinrod force-pushed the 12.0-mig-github_connector branch 2 times, most recently from 4824c8d to fdf089a Compare January 22, 2019 23:14
@cristinamartinrod
Copy link
Member Author

@cubells can you review again, please?

cubells
cubells approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM

Code review and test

pedrobaeza
pedrobaeza requested changes Jan 29, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a pending _description in a wizard model

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
github_connector/__manifest__.py Outdated Show resolved Hide resolved
github_connector/__manifest__.py Show resolved Hide resolved
@pedrobaeza
Copy link
Member

@cristinamartinrod take into account #34 for including here (with the proper patch).

@cristinamartinrod cristinamartinrod force-pushed the 12.0-mig-github_connector branch from 68e099e to 8b2abcd Compare January 30, 2019 09:13
@pedrobaeza
Copy link
Member

@cristinamartinrod please include c399f9f from #34 here

@cristinamartinrod cristinamartinrod mentioned this pull request Feb 13, 2019
Merged
1 task
@enriquemartin @cristinamartinrod
[11.0][FIX] github_connector keyerror 'blog' (OCA#34)
cccce65 
[FIX] github_connector: keyerror 'blog'

Description of the issue/feature this PR addresses:

On new database error when syncing new github organization (example: OCA).
Error traceback: KeyError: 'blog'

Current behavior before PR:

Synchronization gets blog key on `get_odoo_data_from_github` but blog field does not exist.
When it tries to match the key with model attribute we get key error.

Desired behavior after PR is merged:

Get blog key from github data and show it on form view.
@cristinamartinrod cristinamartinrod force-pushed the 12.0-mig-github_connector branch from 8b2abcd to f15151c Compare February 13, 2019 09:28
@cristinamartinrod cristinamartinrod force-pushed the 12.0-mig-github_connector branch from f15151c to 54ffd45 Compare February 13, 2019 09:33
@pedrobaeza pedrobaeza merged commit 2385559 into OCA:12.0 Feb 15, 2019
@pedrobaeza pedrobaeza deleted the 12.0-mig-github_connector branch February 15, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@cubells cubells cubells approved these changes

Assignees
No one assigned
Labels
approved needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.