[16.0][MIG] github_connector: Migration to version 16.0 #118

carolinafernandez-tecnativa · 2024-01-08T18:57:11Z

Standard migration to v16
Add python external dependecies: responses in requirements.txt and manifest.py in order to avoid error message "ModuleNotFoundError: No module named 'responses'"

…hod. [FIX] Add the organization_id.github_login to the github url Making the github url the form: https://github.com/OCA/account-analytic/tree/9.0 and not the https://github.com/account-analytic/tree/9.0 before this commit [IMP] Make travis happy [IMP] Fix error with teams sync We already have the organization in the team data, and github does not provide anymore in the result for the team data.

@astirpe

[IMP] robustness courtesy @astirpe [FIX] warning message, courtesy @lasley and @astirpe [FIX] typo [UPD] add V11 serie in demo data [FIX] various typo [REF] rename milestone into serie courtesy @sbidoul

[IMP] raise error instead of logging in case of duplicates To avoid creating additional duplicates.

[FIX] add ondelete cascade [FIX] team creation from odoo [FIX] possibility to recursively load an existing object

[REF] github_connector: Fix typo "should not => does not" (OCA#6)

[FIX] github_connector: remove duplicated group

* Fixed JSON response parsing issue while fetching data by URL

@RoelAdriaans

* [IMP] Add try-except on branch analyze action Add try-except statements on analyze actions that could potentially crash the analyze process. * [REF] Fix error logging Changes include: - fix error values - use error instead of warning * [IMP] Fix error in analyze call Fix a programming mistake in the analyze call. By @RoelAdriaans * [IMP] Bump version number of github_connector Bump the version number of github_connector to '11.0.1.1.1'. * [IMP] Bump version number of github_connector Bump the version number of github_connector_odoo to '11.0.1.1.1'.

To play nice with Sentry.

[FIX] github_connector: keyerror 'blog' Description of the issue/feature this PR addresses: On new database error when syncing new github organization (example: OCA). Error traceback: KeyError: 'blog' Current behavior before PR: Synchronization gets blog key on `get_odoo_data_from_github` but blog field does not exist. When it tries to match the key with model attribute we get key error. Desired behavior after PR is merged: Get blog key from github data and show it on form view.

…user (OCA#41)

If source path does not exists before adding it to modules path, styles on website are corrupted, making impossible load them from assets.

Don't mix bytes and str

There's a mix between self and branch arguments in analyze methods.

…functional This field allows to define where addons are located, but it's hidden right now, because not everything is properly adjusted for paths different from root. Making this working, there's no need to hide the field.

linter Linter Linter default value to empty string in get()'s secure the code improvment of the code coding style coding style

Using os.command gets hung when there's a problem deleting the folder (for example, when no permissions), so this stucks the cron method or the manual process of updating source code. We avoid it using the Python utility for that through shutil. We also avoid an exception in that case enclosing the sentence in a try/except clause.

github_connector/models/github_repository_branch.py

victoralmau

Some non-blocking suggestions.

Please check all tabs of all menus to display the data correctly (colspan), some examples:

Organizations > Github
Teams > Github
Repositories > Github

github_connector/models/abstract_github_model.py

github_connector/report/github_repository_branch_rule_info_report.py

pedrobaeza · 2024-02-29T08:02:50Z

Is this still WIP?

carolinafernandez-tecnativa · 2024-02-29T09:50:39Z

Is this still WIP?

no, it is ready for review Thanks!

victoralmau · 2024-03-05T08:22:00Z

Please check all tabs of all menus to display the data correctly (colspan), some examples:
* Organizations > Github

* Teams > Github

* Repositories > Github

This is still pending (I haven't seen any changes to it), can you check it?

carolinafernandez-tecnativa · 2024-03-05T18:40:44Z

03f944e

I have changed on this: 03f944e

On which section is not displaying well or could you please give me an example ? thanks!
I have checked and it looks okay.

victoralmau

Code review OK.

Can you check "Light Sync" and "Full Sync" buttons in "Github" tabs to make them display a little better?

carolinafernandez-tecnativa · 2024-03-06T19:22:35Z

Code review OK.

Can you check "Light Sync" and "Full Sync" buttons in "Github" tabs to make them display a little better?

I could't get a better display for them, do you have any idea how to do it?

pedrobaeza · 2024-03-07T08:45:35Z

/ocabot migration github_connector

requirements.txt

pedrobaeza · 2024-03-07T18:23:05Z

/ocabot migration github_connector

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-03-07T18:23:58Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-118-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-03-07T18:27:27Z

Congratulations, your PR was merged at 31a788f. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 30 commits January 8, 2024 14:50

[ADD] two modules from 8.0 WIP branch

1e72b98

[PORT] replace obsolete tag openerp-data by odoo

f09577a

[PORT] replace select=True by index=True

4387cf2

[PORT] adapt xml inheritance to v10.0 (menu, form, ...)

6a41b61

[REM] remove issue, comment, commit, author object

2753087

[IMP] various improvments

8a5eedc

[IMP] readme, courtesy @elicoidal

c323c08

[FIX] don't fail on empty url patterns

5bd7b31

[FIX] various improvments

28db57f

[FIX] remove obsolete markdown requirement

213286f

[IMP] robustness courtesy @astirpe [FIX] warning message, courtesy @lasley and @astirpe [FIX] typo [UPD] add V11 serie in demo data [FIX] various typo [REF] rename milestone into serie courtesy @sbidoul

[IMP] log error in case of multiple partners with same github id

c82a7a2

[IMP] raise error instead of logging in case of duplicates To avoid creating additional duplicates.

[FIX] incorrect call to __super_

535c95f

[FIX] add ondelete cascade [FIX] team creation from odoo [FIX] possibility to recursively load an existing object

Typos (double "you" and comma)

238763d

[REF] github_connector: Fix typo "should not => does not" (OCA#6)

[MIG] github_connector: Migration to 11.0

04efff5

[FIX] github_connector: remove duplicated group

Fixed issue while fetching organization, user and members in v11

e2a1796

* Fixed JSON response parsing issue while fetching data by URL

[IMP] github_connector: Add brand new icon and menu icon

fa58d55

Trivial python3 fix

a1f3228

[FIX] logging interpolation

e07eec7

To play nice with Sentry.

[12.0][MIG] github_connector: Migration to v12

bfde03f

[IMP] github connector: All modules only can be access by github app …

506177d

…user (OCA#41)

[FIX] github_connector: Ensure source path exists always

0f4c048

If source path does not exists before adding it to modules path, styles on website are corrupted, making impossible load them from assets.

[FIX] github_connector: Good comparison

f96676c

Don't mix bytes and str

[IMP] github_connector*: Homogeneize API

c423bc2

There's a mix between self and branch arguments in analyze methods.

introduce usage of github_token

2d4e5d2

linter Linter Linter default value to empty string in get()'s secure the code improvment of the code coding style coding style

[IMP] github_connector: black, isort

ec9bc69

pedrobaeza requested a review from victoralmau January 13, 2024 15:59

pedrobaeza reviewed Jan 13, 2024

View reviewed changes

github_connector/models/github_repository_branch.py Outdated Show resolved Hide resolved

carolinafernandez-tecnativa force-pushed the 16.0-mig-github_connector branch from 5bdf9f1 to 0bbc5d4 Compare January 15, 2024 08:47

victoralmau suggested changes Jan 31, 2024

View reviewed changes

carolinafernandez-tecnativa force-pushed the 16.0-mig-github_connector branch 4 times, most recently from 27a634b to 03f944e Compare February 1, 2024 13:56

victoralmau approved these changes Mar 6, 2024

View reviewed changes

OCA-git-bot added this to the 16.0 milestone Mar 7, 2024

OCA-git-bot mentioned this pull request Mar 7, 2024

Migration to version 16.0 #89

Open

2 tasks

pedrobaeza reviewed Mar 7, 2024

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

[MIG] github_connector: Migration to 16.0

642b26b

carolinafernandez-tecnativa force-pushed the 16.0-mig-github_connector branch from 03f944e to 642b26b Compare March 7, 2024 18:15

pedrobaeza approved these changes Mar 7, 2024

View reviewed changes

OCA-git-bot added the approved label Mar 7, 2024

OCA-git-bot added the bot is merging ⏳ label Mar 7, 2024

OCA-git-bot merged commit 0301f47 into OCA:16.0 Mar 7, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 7, 2024

pedrobaeza deleted the 16.0-mig-github_connector branch March 7, 2024 19:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] github_connector: Migration to version 16.0 #118

[16.0][MIG] github_connector: Migration to version 16.0 #118

carolinafernandez-tecnativa commented Jan 8, 2024 •

edited

Loading

victoralmau left a comment

pedrobaeza commented Feb 29, 2024

carolinafernandez-tecnativa commented Feb 29, 2024 •

edited

Loading

victoralmau commented Mar 5, 2024

carolinafernandez-tecnativa commented Mar 5, 2024

victoralmau left a comment

carolinafernandez-tecnativa commented Mar 6, 2024

pedrobaeza commented Mar 7, 2024

pedrobaeza commented Mar 7, 2024

pedrobaeza left a comment

OCA-git-bot commented Mar 7, 2024

OCA-git-bot commented Mar 7, 2024

[16.0][MIG] github_connector: Migration to version 16.0 #118

[16.0][MIG] github_connector: Migration to version 16.0 #118

Conversation

carolinafernandez-tecnativa commented Jan 8, 2024 • edited Loading

victoralmau left a comment

Choose a reason for hiding this comment

pedrobaeza commented Feb 29, 2024

carolinafernandez-tecnativa commented Feb 29, 2024 • edited Loading

victoralmau commented Mar 5, 2024

carolinafernandez-tecnativa commented Mar 5, 2024

victoralmau left a comment

Choose a reason for hiding this comment

carolinafernandez-tecnativa commented Mar 6, 2024

pedrobaeza commented Mar 7, 2024

pedrobaeza commented Mar 7, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 7, 2024

OCA-git-bot commented Mar 7, 2024

carolinafernandez-tecnativa commented Jan 8, 2024 •

edited

Loading

carolinafernandez-tecnativa commented Feb 29, 2024 •

edited

Loading