[ADD] github_connector_pull_request

[SirAionTech]

No description provided.

[legalsylvain]

nice work ! code review. No test.
I wonder if we should add a cron to synchronize PR regularly.

like in the core module : https://github.com/OCA/interface-github/blob/14.0/github_connector/data/ir_cron.xml

[SirAionTech]

nice work ! code review. No test.
I wonder if we should add a cron to synchronize PR regularly.

like in the core module : https://github.com/OCA/interface-github/blob/14.0/github_connector/data/ir_cron.xml

Thanks for your review!
I was looking forward to your feedback specifically because you implemented the core modules.
I added the CRON

[legalsylvain]

Design question : Why create a dedicated module.

• If we install github_connector, we expect to have the possibility to fetch also the PRs, not only the branches, and the code ?
• if then, we want to implement "github_connector_issue", it will ask a refactor, because a lot of thing are common between issues and pull requests, so we should create an fourth module "abstract".
• the PR / issues improvment are written in the roadmap of the main module : https://github.com/OCA/interface-github/tree/14.0/github_connector#known-issues-roadmap

Proposing to improve the existing module. What do you think ?

Question : did you thought to fetch also comments ?

note : I began to work on PR / issue / comment in V8. If it can help :
https://github.com/OCA/interface-github/pull/1/files#diff-a1b4664848d92d0cabbe8108e17e7480403c09afbb1ee07242878b4273f3d564R18

[SirAionTech]

• If we install github_connector, we expect to have the possibility to fetch also the PRs, not only the branches, and the code ?
  ...

Proposing to improve the existing module. What do you think ?

I see Pull Requests as a temporary object, I think most users should only be interested in the main branches.
The ordinary user might then be not interested in the Pull Requests, so it should not install the additional module.

We implemented this module because we are also interested in what is the work in progress of some repositories.

did you thought to fetch also comments ?

No

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[SirAionTech]

Any news on this one?

[legalsylvain]

I'm abstaining on this one!

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[SirAionTech]

Rebased on 14.0.