Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] hr_employee_age #1220

Merged
merged 16 commits into from
Apr 18, 2023
Merged

Conversation

destroT
Copy link

@destroT destroT commented Apr 6, 2023

No description provided.

@destroT destroT mentioned this pull request Apr 6, 2023
27 tasks
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direct migration

@etobella
Copy link
Member

etobella commented Apr 6, 2023

/ocabot migration hr_employee_age

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 6, 2023
@luistorresm
Copy link
Contributor

@destroT
Copy link
Author

destroT commented Apr 13, 2023

@luistorresm Is this okay or do I need to make other changes?

@luistorresm
Copy link
Contributor

luistorresm commented Apr 13, 2023

@luistorresm Is this okay or do I need to make other changes?

Yes @destroT

Only could you rename to commit message to [MIG] hr_employee_age: Migration to 16.0, please

@destroT
Copy link
Author

destroT commented Apr 14, 2023

Is this okay or do I need to make other changes?

Yes @destroT

Only could you

now should be fine

@luistorresm
Copy link
Contributor

Is this okay or do I need to make other changes?

Yes @destroT
Only could you

now should be fine

Hello @destroT

I still see [16.0][MIG] hr_employee_age

@destroT destroT force-pushed the 16.0-mig-hr_employee_age branch 3 times, most recently from d8407c8 to 9377507 Compare April 14, 2023 16:16
@luistorresm
Copy link
Contributor

Hello @destroT

Sorry, I fix the last message, the correct commit is "[MIG] hr_employee_age: Migration to 16.0"

But you are ok, only need to change the commit [16.0][MIG] hr_employee_age by [MIG] hr_employee_age: Migration to 16.0

You can see it on the guidelines

@destroT destroT force-pushed the 16.0-mig-hr_employee_age branch 2 times, most recently from 15c8e95 to dc42f64 Compare April 17, 2023 10:11
@destroT
Copy link
Author

destroT commented Apr 17, 2023

Hello @destroT

Sorry, I fix the last message, the correct commit is "[MIG] hr_employee_age: Migration to 16.0"

But you are ok, only need to change the commit [16.0][MIG] hr_employee_age by [MIG] hr_employee_age: Migration to 16.0

You can see it on the guidelines

Finally it should be ok, thanks for the support

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@nimarosa
Copy link
Contributor

Merging.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1220-by-nimarosa-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f999374 into OCA:16.0 Apr 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ad86a2e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.