Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] fieldservice_sale_recurring #1149

Merged
merged 63 commits into from
Dec 18, 2024

Conversation

brian10048
Copy link
Contributor

No description provided.

@brian10048 brian10048 added this to the 16.0 milestone Dec 13, 2023
@brian10048 brian10048 force-pushed the 16.0-mig-fieldservice_sale_recurring branch from 92d493f to 047918b Compare December 13, 2023 15:36
@brian10048 brian10048 self-assigned this Dec 13, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
Copy link

github-actions bot commented Sep 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
@github-actions github-actions bot closed this Oct 13, 2024
@dreispt dreispt reopened this Oct 18, 2024
@dreispt dreispt added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Oct 18, 2024
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking comment, not blocking

fieldservice_sale_recurring/models/sale_order.py Outdated Show resolved Hide resolved
max3903 and others added 14 commits December 18, 2024 09:32
Currently translated at 60.0% (12 of 20 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/
Currently translated at 100.0% (21 of 21 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/es_CL/
- Was not calling super properly and FSM orders on the sale line that were not recurring orders were not being created.
- Delete unused computed field.
francesco-ooops and others added 18 commits December 18, 2024 09:32
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/it/
Adapt for logic changes in fieldservice_sale
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/es/
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/it/
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/it/
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring
Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/es_AR/
…generate wrong fsm_order (ex: Assigned To not set, start date wrong, recuring info not set, ...)
Do not copy FSM Order or FSM Recurring Orders on sale order line
@brian10048 brian10048 force-pushed the 16.0-mig-fieldservice_sale_recurring branch from 047918b to fafc3c2 Compare December 18, 2024 14:36
@brian10048 brian10048 force-pushed the 16.0-mig-fieldservice_sale_recurring branch from fafc3c2 to 7ed949e Compare December 18, 2024 14:43
@brian10048
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1149-by-brian10048-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 20bf04a into OCA:16.0 Dec 18, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 33df383. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.