Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] Update oca_dependencies.txt, webservice module in web-api #735

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

angelmoya
Copy link
Member

No description provided.

Copy link
Member

@yaseentai yaseentai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

@simahawk
Copy link
Contributor

Thanks for your change. However, this file is not needed anymore.

@sbidoul IMO we should delete all oca_dependencies.txt from all the repos where we switched CI to use PIP mode.
WDYT?

@sbidoul
Copy link
Member

sbidoul commented Mar 30, 2023

IMO we should delete all oca_dependencies.txt from all the repos where we switched CI to use PIP mode.
WDYT?

@simahawk AFIK this file is not present in any of 15 and 16 branches. For older branches I guess I don't mind if people maintain it manually if they need it for existing workflows. But for sure we should not reintroduce it in newer branches.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 30, 2023
@simahawk
Copy link
Contributor

simahawk commented Aug 9, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-735-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d242fc1. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit d242fc1 into OCA:14.0 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants