-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #940
Draft
bizzappdev
wants to merge
74
commits into
OCA:18.0
Choose a base branch
from
BizzAppDev-Systems:18.0-mig-delivery_postlogistics-BAD
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #940
bizzappdev
wants to merge
74
commits into
OCA:18.0
from
BizzAppDev-Systems:18.0-mig-delivery_postlogistics-BAD
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix 'PostLogistics' terms * make 'Package Code' required for PostLogistics delivery packaging * show a link listing available package codes for PostLogistics delivery packaging * update README
Some chars are disallowed from postlogistics API ("|", "", "<", ">") and output json should be sanitized
history_ids has been removed as below link. So the code is obsoleted. odoo/odoo@b3180c8#diff-9a22420c4a72cc9b6d558b3d832846c2e44a4f3731c6df9579d66c6279c4804eL54-L57 _get_origin_pickings is to determine number of pickings of a sale order. So it should get pickings from sale_id of found picking.
The cassette `tests/fixtures/cassettes/test_store_label.yaml` should be updated as the label was failed to decode in both 13.0 and 14.0. * https://github.com/odoo/odoo/blob/13.0/odoo/addons/base/models/ir_attachment.py#L212 * https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L554 We can remove the method _selection_file_type with below reasons. * It is used in base_delivery_carrier_label but was removed on Sep 5, 2019 https://github.com/OCA/delivery-carrier/blame/12.0/base_delivery_carrier_label/models/shipping_label.py#L15 * PR migration to 13.0 of base_delivery_carrier_label was merged on Oct 22, 2020 https://github.com/OCA/delivery-carrier/pull/251/files * Dependency on base_delivery_carrier_label was removed in migration to 14.0 on Apr 14 2021 OCA@4ba2b56#diff-f16078e35000c05a9b63f5e7e04b6f5fd50eadae8b14a45aa9c1eb078031060cL12 OCA@4ba2b56#diff-08c11b571d9c0b0c509c3922c77f407ef4c429473fda9bc2d4d542520e7a4e3fR12
… for delivery type other than postlogistics.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/
Postlogistics limit for fields such as name, street and city, is 35 chars for the recipient fields but is limited to 25 characters.
Sometimes due to API error it may happen we don't receive anything back when requesting token. In this case we want to show meaningful message.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/
If a stock.picking is created and in the same transaction we generate a label, when the webservice returns an error, the module rollbacks the transaction, so 'self' is empty and will fail with: Record does not exist or has been deleted. (Record: stock.picking(8211067,), User: 6) When trying to write the tracking number, and will therefore not raise the details of the error.
The tests from d5c3f73 failed due to partner city being required
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-16.0/delivery-carrier-16.0-delivery_postlogistics Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_postlogistics/
bizzappdev
force-pushed
the
18.0-mig-delivery_postlogistics-BAD
branch
6 times, most recently
from
January 28, 2025 10:50
92b5ea2
to
b156eb5
Compare
bizzappdev
force-pushed
the
18.0-mig-delivery_postlogistics-BAD
branch
from
January 29, 2025 05:06
054d771
to
f9389fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.