Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16][IMP] delivery_package_number: changes on delivery_package_number_document #939

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

adasatorres
Copy link

@adasatorres adasatorres commented Jan 24, 2025

Good morning, I suggest this change to allow configuring the report with a different paper format than the default one. For example, if you need to create labels on an A4 sheet, the line break forced by <div style="page-break-before:always;" /> wastes space unnecessarily.

The proposed change forces a page break if the label is cut off.

@adasatorres adasatorres force-pushed the 16.0-imp-delivery_package_number branch from c9be315 to 5fcc69a Compare January 24, 2025 09:28
Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this change make the module more flexible at the same time that keeps the initial behavior.

Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

@antoniodavid
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants