[16.0][ADD] sale_order_warehouse_from_delivery_carrier #684

geomer198 · 2023-08-06T19:20:38Z

This module allows to set warehouse in Sales Order based on selected shipping method.

ivs-cetmix

Functional ok

sale_order_wh_from_delivery_carrier/models/sale_order.py

GabbasovDinar

LGTM

OCA-git-bot · 2023-08-30T21:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix · 2023-10-13T10:02:10Z

Hey @OCA/logistics-maintainers could you please have a look at this?

rousseldenis · 2023-10-13T11:32:59Z

@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.

ivs-cetmix · 2023-10-13T11:34:38Z

@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.

Thank you for the feedback. Any ideas how this module name should look like?

rousseldenis · 2023-11-10T07:07:40Z

sale_order_wh_from_delivery_carrier/models/delivery_carrier.py

+    _inherit = "delivery.carrier"
+
+    so_warehouse_id = fields.Many2one(
+        comodel_name="stock.warehouse", string="SO Warehouse"


A help is welcome here.

rousseldenis · 2023-11-10T07:11:50Z

sale_order_wh_from_delivery_carrier/tests/test_module_flow.py

+
+@tagged("post_install", "-at_install")
+class TestModuleFlow(TransactionCase):
+    def setUp(self):


Use classmethod instead.

rousseldenis · 2023-11-10T07:12:30Z

test-requirements.txt

@@ -1,3 +1,5 @@
 odoo-test-helper
 vcrpy
 vcrpy-unittest
+odoo-addon-delivery_roulier @ git+https://github.com/OCA/delivery-carrier.git@refs/pull/731/head#subdirectory=setup/delivery_roulier


@geomer198 Why adding these as they are not in this module dependencies ?

Added for fixing broken tests in delivery_roulier module.

geomer198 · 2023-11-19T13:02:56Z

@rousseldenis Could you please check my changes?

jbaudoux · 2024-07-24T08:12:51Z

sale_order_warehouse_from_delivery_carrier/readme/USAGE.rst

+this warehouse will be automatically set in the quotation.
+
+**Note**:
+warehouse will be NOT updated if Sales Order is already confirmed.


Suggested change

warehouse will be NOT updated if Sales Order is already confirmed.

The warehouse will NOT be updated if the sales order is already confirmed.

geomer198 · 2024-07-24T09:22:41Z

@rousseldenis, @jbaudoux Could you check again?

jbaudoux · 2024-07-24T14:10:02Z

@rousseldenis, @jbaudoux Could you check again?

Thanks.

/ocabot merge nobump

OCA-git-bot · 2024-07-24T14:10:09Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-684-by-jbaudoux-bump-nobump, awaiting test results.

Signed-off-by jbaudoux

OCA-git-bot · 2024-07-24T14:17:09Z

@jbaudoux The merge process could not be finalized, because command twine check odoo_addon_sale_order_warehouse_from_delivery_carrier-16.0.1.0.0.3-py3-none-any.whl failed with output:

Checking 
odoo_addon_sale_order_warehouse_from_delivery_carrier-16.0.1.0.0.3-py3-none-any.
whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         No content rendered from RST source.                                   
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.

OCA-git-bot · 2024-07-24T14:32:56Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix

You need to add DESCRIPTION.rst

jbaudoux · 2024-07-25T12:17:11Z

@geomer198 can you squash the commits?

ivs-cetmix

LGTM

OCA-git-bot · 2024-07-25T13:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

jbaudoux · 2024-07-25T13:49:33Z

/ocabot merge nobump

OCA-git-bot · 2024-07-25T13:49:40Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-684-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot · 2024-07-25T13:57:07Z

Congratulations, your PR was merged at 6d9ecd0. Thanks a lot for contributing to OCA. ❤️

geomer198 force-pushed the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch 2 times, most recently from aa2193c to e9ff006 Compare August 7, 2023 13:36

ivs-cetmix approved these changes Aug 22, 2023

View reviewed changes

GabbasovDinar reviewed Aug 24, 2023

View reviewed changes

sale_order_wh_from_delivery_carrier/models/sale_order.py Outdated Show resolved Hide resolved

geomer198 force-pushed the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch from c0d260b to b444782 Compare August 29, 2023 18:59

GabbasovDinar approved these changes Aug 30, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Aug 30, 2023

ivs-cetmix force-pushed the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch from b444782 to e807ab2 Compare October 14, 2023 11:51

geomer198 force-pushed the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch 6 times, most recently from 219df31 to 70ed02b Compare November 9, 2023 20:01

geomer198 mentioned this pull request Nov 9, 2023

[16.0][FIX] Tests are fixed. #731

Closed

rousseldenis requested changes Nov 10, 2023

View reviewed changes

OCA-git-bot removed approved ready to merge labels Nov 10, 2023

rousseldenis added the needs review label Nov 10, 2023

rousseldenis added this to the 16.0 milestone Nov 10, 2023

geomer198 force-pushed the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch from 83f7881 to e4bf222 Compare November 19, 2023 12:59

geomer198 force-pushed the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch from e4bf222 to a0b6867 Compare December 8, 2023 20:03

jbaudoux reviewed Jul 24, 2024

View reviewed changes

jbaudoux approved these changes Jul 24, 2024

View reviewed changes

OCA-git-bot added the approved label Jul 24, 2024

OCA-git-bot added a commit that referenced this pull request Jul 24, 2024

Merge PR #684 into 16.0

7e02b26

Signed-off-by jbaudoux

OCA-git-bot added the bot is merging ⏳ label Jul 24, 2024

OCA-git-bot added ready to merge and removed bot is merging ⏳ labels Jul 24, 2024

ivs-cetmix suggested changes Jul 24, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jul 24, 2024

[ADD] sale_order_warehouse_from_delivery_carrier: Module added.

7dc7743

geomer198 force-pushed the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch from e2beefb to 7dc7743 Compare July 25, 2024 12:18

ivs-cetmix approved these changes Jul 25, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 25, 2024

OCA-git-bot added the bot is merging ⏳ label Jul 25, 2024

OCA-git-bot merged commit 82bcf83 into OCA:16.0 Jul 25, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 25, 2024

ivs-cetmix deleted the 16.0-t2753-sale_order_wh_from_delivery_carrier-add branch July 25, 2024 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] sale_order_warehouse_from_delivery_carrier #684

[16.0][ADD] sale_order_warehouse_from_delivery_carrier #684

geomer198 commented Aug 6, 2023

ivs-cetmix left a comment

GabbasovDinar left a comment

OCA-git-bot commented Aug 30, 2023

ivs-cetmix commented Oct 13, 2023

rousseldenis commented Oct 13, 2023

ivs-cetmix commented Oct 13, 2023

rousseldenis Nov 10, 2023

rousseldenis Nov 10, 2023

rousseldenis Nov 10, 2023

geomer198 Nov 19, 2023

geomer198 commented Nov 19, 2023

jbaudoux Jul 24, 2024 •

edited

Loading

geomer198 commented Jul 24, 2024

jbaudoux commented Jul 24, 2024

OCA-git-bot commented Jul 24, 2024

OCA-git-bot commented Jul 24, 2024

OCA-git-bot commented Jul 24, 2024

ivs-cetmix left a comment

jbaudoux commented Jul 25, 2024

ivs-cetmix left a comment

OCA-git-bot commented Jul 25, 2024

jbaudoux commented Jul 25, 2024

OCA-git-bot commented Jul 25, 2024

OCA-git-bot commented Jul 25, 2024

	warehouse will be NOT updated if Sales Order is already confirmed.
	The warehouse will NOT be updated if the sales order is already confirmed.

[16.0][ADD] sale_order_warehouse_from_delivery_carrier #684

[16.0][ADD] sale_order_warehouse_from_delivery_carrier #684

Conversation

geomer198 commented Aug 6, 2023

ivs-cetmix left a comment

Choose a reason for hiding this comment

GabbasovDinar left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 30, 2023

ivs-cetmix commented Oct 13, 2023

rousseldenis commented Oct 13, 2023

ivs-cetmix commented Oct 13, 2023

rousseldenis Nov 10, 2023

Choose a reason for hiding this comment

rousseldenis Nov 10, 2023

Choose a reason for hiding this comment

rousseldenis Nov 10, 2023

Choose a reason for hiding this comment

geomer198 Nov 19, 2023

Choose a reason for hiding this comment

geomer198 commented Nov 19, 2023

jbaudoux Jul 24, 2024 • edited Loading

Choose a reason for hiding this comment

geomer198 commented Jul 24, 2024

jbaudoux commented Jul 24, 2024

OCA-git-bot commented Jul 24, 2024

OCA-git-bot commented Jul 24, 2024

OCA-git-bot commented Jul 24, 2024

ivs-cetmix left a comment

Choose a reason for hiding this comment

jbaudoux commented Jul 25, 2024

ivs-cetmix left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 25, 2024

jbaudoux commented Jul 25, 2024

OCA-git-bot commented Jul 25, 2024

OCA-git-bot commented Jul 25, 2024

jbaudoux Jul 24, 2024 •

edited

Loading