Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] crm_lead_code: Migration to 18.0 #609

Open
wants to merge 31 commits into
base: 18.0
Choose a base branch
from
Open

[MIG] crm_lead_code: Migration to 18.0 #609

wants to merge 31 commits into from
+1,283 −0

Conversation

BhaveshHeliconia
Copy link

No description provided.

patel1008b
patel1008b approved these changes Nov 27, 2024
View reviewed changes
Copy link

@patel1008b patel1008b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review, LGTM

CRogos
CRogos reviewed Feb 20, 2025
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cleanup the bot commits? I've marked some examples, but there are more.
image

I hope the the push will also recreate the runboat for testing

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-crm_lead_code branch 2 times, most recently from f6d7aea to 6d4d297 Compare February 21, 2025 05:06
@BhaveshHeliconia
Copy link
Author

@CRogos , Please review.it's done!

@CRogos
Copy link

CRogos commented Feb 21, 2025

There are still more commits which can be merged.
Here is a link to the migration documentation: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

@BhaveshHeliconia
Copy link
Author

@CRogos, Please review!

@CRogos
Copy link

CRogos commented Feb 21, 2025

do you know why the tests are failing? Maybe we should make a rebase?

also there are still some weblate and oca-* commits.

CRogos
CRogos approved these changes Feb 21, 2025
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM and it is working.

Not sure why the tests fail, and some Commits can still be squashed.

nicolasramos and others added 13 commits February 25, 2025 14:15
@nicolasramos @BhaveshHeliconia
[10.0][MIG] crm_lead_code (OCA#156)
2135a81
@sbidoul @BhaveshHeliconia
remove obsolete .pot files [ci skip]
795ee45
@marylla @BhaveshHeliconia
Translated using Weblate (German)
b57c1da 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-10.0/crm-10.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-10-0/crm-10-0-crm_lead_code/de/
@keshrath @BhaveshHeliconia
[MIG] crm_lead_code: Migration to 12.0
97ead0e 
[UPD] Update crm_lead_code.pot
@BhaveshHeliconia
Translated using Weblate (Portuguese (Brazil))
4b3042b 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_code/pt_BR/
@murtuzasaleh @BhaveshHeliconia
[WIP][13.0][MIG] crm_lead_code
df5ac3d
@murtuzasaleh @BhaveshHeliconia
[FIX] Travis
dbfb348 
[UPD] Update crm_lead_code.pot

[UPD] README.rst
@newtratip @BhaveshHeliconia
[MIG] crm_lead_code: Migration to 14.0
31217e1 
[UPD] Update crm_lead_code.pot
@ibuioli @BhaveshHeliconia
Added translation using Weblate (Spanish (Argentina))
1a8cfc1
@ibuioli @BhaveshHeliconia
Translated using Weblate (Spanish (Argentina))
6905591 
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-14.0/crm-14.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es_AR/
@Mat-moran @BhaveshHeliconia
Translated using Weblate (Spanish)
dfdc9ec 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-14.0/crm-14.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es/
@santostelmo @BhaveshHeliconia
[MIG] crm_lead_code: Migration to 15.0
2709ae6
@Noel000 @BhaveshHeliconia
Added translation using Weblate (Catalan)
3cd54b3
ajaniszewska-dev and others added 13 commits February 25, 2025 14:15
@ajaniszewska-dev @BhaveshHeliconia
Translated using Weblate (French)
4a9f3bb 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-15.0/crm-15.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/fr/
@Noel000 @BhaveshHeliconia
Translated using Weblate (Catalan)
ec029cd 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-15.0/crm-15.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/ca/
@francesco-ooops @BhaveshHeliconia
Translated using Weblate (Italian)
20593bc 
Currently translated at 66.6% (2 of 3 strings)

Translation: crm-15.0/crm-15.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/it/
@BhaveshHeliconia
[MIG] crm_lead_code: Migration to 16.0
b244676
@sysadminmatmoz @BhaveshHeliconia
Translated using Weblate (Slovenian)
2eb47df 
Currently translated at 25.0% (1 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/sl/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
15e60ba 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/it/
@Ivorra78 @BhaveshHeliconia
Translated using Weblate (Spanish)
1f9522b 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es/
@ibuioli @BhaveshHeliconia
Translated using Weblate (Spanish (Argentina))
4cc0028 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es_AR/
@peluko00 @BhaveshHeliconia
[MIG] crm_lead_code: Migration to 17.0
3b2037e
@BhaveshHeliconia
Translated using Weblate (Portuguese (Brazil))
b100cde 
Currently translated at 75.0% (3 of 4 strings)

Translation: crm-17.0/crm-17.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/
@SottomaiorMacedoTec @BhaveshHeliconia
Translated using Weblate (Portuguese (Brazil))
6c244ca 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-17.0/crm-17.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/
@CRogos @BhaveshHeliconia
[IMP] crm_lead_code: space get removed when other view changes name f…
246cd1c 
…ield
@BhaveshHeliconia
[IMP] crm_lead_code: pre-commit auto fixes
bb5eac4
@BhaveshHeliconia
Copy link
Author

Hello @CRogos Commits are squashed and Tests are also clear now.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

CRogos
CRogos suggested changes Feb 25, 2025
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just found one more thing.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogos CRogos CRogos approved these changes

@patel1008b patel1008b patel1008b approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.