Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] crm_partner_assign: Migration to 17.0 #606

Open
wants to merge 6 commits into
base: 17.0
Choose a base branch
from

Conversation

MohamedOsman7
Copy link

Same changes from #538 with cleaned commit history.

@MohamedOsman7 MohamedOsman7 mentioned this pull request Nov 12, 2024
20 tasks
@rousseldenis
Copy link

/ocabot migration crm_partner_assign

Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MohamedOsman7
Copy link
Author

MohamedOsman7 commented Nov 19, 2024

@peluko00 @ppyczko could you please make a review

help="Partner this case has been assigned to.",
related="partner_contact_assigned_id.commercial_partner_id",
store=True,
readonly=True,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the readonly in view.

date_partner_assign = fields.Date(
compute="_compute_date_partner_assign",
string="Partner Assignment Date",
readonly=False,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove here

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-crm_partner_assign branch from 264c642 to 439aef5 Compare November 19, 2024 13:47
@MohamedOsman7
Copy link
Author

@peluko00 thanks for your review, i made the requested changes

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MohamedOsman7
Copy link
Author

@rousseldenis could you please merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants