-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] crm_partner_assign: Migration to 17.0 #606
base: 17.0
Are you sure you want to change the base?
Conversation
/ocabot migration crm_partner_assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
help="Partner this case has been assigned to.", | ||
related="partner_contact_assigned_id.commercial_partner_id", | ||
store=True, | ||
readonly=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the readonly in view.
date_partner_assign = fields.Date( | ||
compute="_compute_date_partner_assign", | ||
string="Partner Assignment Date", | ||
readonly=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove here
264c642
to
439aef5
Compare
@peluko00 thanks for your review, i made the requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review and tested in runboat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@rousseldenis could you please merge |
Same changes from #538 with cleaned commit history.