Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] marketing_crm_partner: Migration to 17.0 #603

Merged
merged 30 commits into from
Nov 20, 2024

Conversation

MohamedOsman7
Copy link

No description provided.

yajo and others added 29 commits November 5, 2024 14:12
This module extends the functionality of the CRM to support having the tracking
fields available in the partner and copy them there automatically when the
partner is created from a lead/opportunity.
Currently translated at 100.0% (9 of 9 strings)

Translation: crm-11.0/crm-11.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-marketing_crm_partner/de/
Currently translated at 100.0% (9 of 9 strings)

Translation: crm-11.0/crm-11.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-marketing_crm_partner/gl/
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-12.0/crm-12.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/pt_BR/
Since odoo/odoo@e183393, we need to reassign the partner to the lead, as the
method doesn't do it by itself.
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-12.0/crm-12.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/hr/
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-12.0/crm-12.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/ca/
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-12.0/crm-12.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/es/
Currently translated at 83.3% (5 of 6 strings)

Translation: crm-12.0/crm-12.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-12.0/crm-12.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-marketing_crm_partner/sl/
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-13.0/crm-13.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-marketing_crm_partner/es_AR/
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-14.0/crm-14.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-marketing_crm_partner/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: crm-15.0/crm-15.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-marketing_crm_partner/es/
Currently translated at 100.0% (9 of 9 strings)

Translation: crm-15.0/crm-15.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-marketing_crm_partner/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: crm-16.0/crm-16.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-marketing_crm_partner/pt_BR/
Currently translated at 100.0% (9 of 9 strings)

Translation: crm-16.0/crm-16.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-marketing_crm_partner/sv/
Currently translated at 100.0% (9 of 9 strings)

Translation: crm-16.0/crm-16.0-marketing_crm_partner
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-marketing_crm_partner/es_AR/
@MohamedOsman7
Copy link
Author

@flotho Could you please make a review?

Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + Test LGTM

@MohamedOsman7 MohamedOsman7 mentioned this pull request Nov 5, 2024
20 tasks
@MohamedOsman7
Copy link
Author

@peluko00 @ppyczko could you please also here make a review

Comment on lines 49 to 58
4. Go to **Extra Info > Marketing** and fill those fields: |lead view|
5. **Save**.
6. Click **Convert to Opportunity**.
7. Choose the option **Customer > Create a new customer**. |choose
customer|
8. Click **Create Opportunity**.
9. Click on the name of the newly linked partner. |new linked partner|
10. Go to tab **Sales & Purchases**.
11. There you have the new fulfilled fields in the marketing section.
|partner marketing|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images don't load correctly

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as soon as the PR is merged, the images should be visible. The images point to the 17.0 repo, which should be correct in my opinion.

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are new images in SVG that shouldn't be in that format, but PNG, and corresponding to enterprise snapshots. They should be in community version.

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-marketing_crm_partner branch from e70c794 to 9f1662e Compare November 20, 2024 12:44
@MohamedOsman7
Copy link
Author

@pedrobaeza Thanks for the hint. I made the requested changes.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes

/ocabot migration marketing_crm_partner
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 20, 2024
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-603-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit d5da429 into OCA:17.0 Nov 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7bd5f5c. Thanks a lot for contributing to OCA. ❤️

@MohamedOsman7 MohamedOsman7 deleted the 17.0-mig-marketing_crm_partner branch November 20, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.