Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Apply oca-addons-repo-template to project #1

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

carmenbianca
Copy link
Member

The template used is this commit:
coopiteasy/oca-addons-repo-template@d28f504

At the time of writing, the 12.0 template for OCA is not yet finished,
see OCA/oca-addons-repo-template#117. It was
used regardless, with some modifications.

The modifications are the additions of several tests in pre-commit, and
the bumping of flake8. These modifications are made because the source
material of this repo used these tools. The bumping of flake8 naively
fixes an unresolved problem from the linked PR.

@carmenbianca
Copy link
Member Author

@robinkeunen Can't request a review so pinging you.

The template used is this commit:
<coopiteasy/oca-addons-repo-template@d28f504>

At the time of writing, the 12.0 template for OCA is not yet finished,
see <OCA/oca-addons-repo-template#117>. It was
used regardless, with some modifications.

The modifications are the additions of several tests in pre-commit, and
the bumping of flake8. These modifications are made because the source
material of this repo used these tools. The bumping of flake8 naively
fixes an unresolved problem from the linked PR.

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Copy link
Contributor

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not look into the details, LGTM 👍 Thanks for this precious work.

@carmenbianca
Copy link
Member Author

@robinkeunen Thanks! I cannot merge this myself, so you or another reviewer can do it :)

@robinkeunen robinkeunen merged commit 867a93b into OCA:12.0 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants