[IMP] while clean the odoo module version archive the product #36

bizzappdev · 2018-10-15T15:37:29Z

in reference to OCA/interface-github#30
when the Odoo module version will be deleted it will archive the related product variant.
If there will be no other product related to that product template then it will archive and unpublish the product template.

bizzappdev · 2018-10-15T15:40:04Z

@RoelAdriaans @oscarolar @StephanRozendaal Please review.
cc @elicoidal

elicoidal

LGTM

elicoidal · 2018-10-15T16:57:41Z

apps_product_creator/models/odoo_module_veresion.py

+            product = self.env['product.product'].search(
+                [('odoo_module_version_id', '=', module_version.id)])
+            product.write({'active': False})
+            all_varient_archived = all(


elicoidal · 2018-10-15T16:57:57Z

apps_product_creator/models/odoo_module_veresion.py

@@ -0,0 +1,25 @@
+# Copyright (C) 2017-Today: Odoo Community Association (OCA)


add your name

legalsylvain · 2018-10-15T20:41:20Z

there is a typo in the name of the file
apps_product_creator/models/odoo_module_veresion.py

-> odoo_module_version.py

bizzappdev · 2018-10-16T06:15:41Z

@elicoidal @legalsylvain thanks for your comments. changes are done as suggested. sorry for typos

bizzappdev · 2018-10-17T08:55:38Z

@oscarolar @RoelAdriaans @StephanRozendaal @legalsylvain can you please review this PR.

legalsylvain

LGTM. Thanks for this work.
(code review / no test).

bizzappdev · 2018-10-17T09:23:13Z

once this PR and OCA/interface-github#30 both are merged. I will test on the migration database for the process to fix old products. and then we can proceed for the update on the production.
cc @elicoidal

elicoidal

LGTM

elicoidal · 2018-10-17T16:37:32Z

@oscarolar @RoelAdriaans @StephanRozendaal if you have the opportunity to review?

bizzappdev · 2018-10-22T11:37:52Z

@elicoidal we have already 2 approval e can go ahead if we want.
NOTE: first I have to test on migration the steps to fix things on production.
that I can do after merge of both PRs

oscarolar · 2018-10-22T15:33:53Z

apps_product_creator/models/odoo_module_version.py

+            product = self.env['product.product'].search(
+                [('odoo_module_version_id', '=', module_version.id)])
+            product.write({'active': False})
+            all_variant_archived = all(


Since you are making 3 iterations(all, for, mapped) here I think you should use something with less performance impact:

active_variants = product_obj.search_count( [('product_tmpl_id', '=', product.product_tmpl_id.id), ('active', '=', True)]) if not active_variants: product.product_tmpl_id.write({'active': False, 'website_published': False})

what do you think?

@bizzappdev any feedback on this?

@oscarolar thank you for your suggestion, You are right, I have changed the code as per your suggestion.
cc @elicoidal

I do not see the change here. Did I miss somethign?

something strange with github this still shows the outdated changes.
https://github.com/OCA/apps-store/pull/36/files#diff-87908d4d380713ee148592d4aa5e5069R16
please find the changes it is there already

elicoidal

LGTM

elicoidal · 2018-10-25T08:18:08Z

@oscarolar please have a look but I think your remark was attended

oscarolar · 2018-10-25T14:34:39Z

👍 @bizzappdev @elicoidal

oscarolar

Good to go.

elicoidal · 2018-10-26T06:37:19Z

@gurneyalex The OCA/interface-github + OCA/apps-store repository should be refreshed in our ERP (not urgent)

bizzappdev · 2018-10-26T06:46:00Z

@elicoidal @gurneyalex yes code can be pulled on the server.
for fixing old products/apps I will provide steps by today or tomorrow evening.

elicoidal · 2018-10-26T07:38:31Z

@bizzappdev could you have a look at Travis too because something got broken in the process.

bizzappdev · 2018-10-26T07:43:22Z

@elicoidal https://travis-ci.org/OCA/apps-store/builds/446015225?utm_source=github_status&utm_medium=notification
seems proper. not sure where you are pointing.

elicoidal · 2018-10-26T07:47:53Z

https://travis-ci.org/OCA/apps-store/builds/446534958?utm_medium=notification&utm_source=email I am not sure why transifex is failing though: not sure it is important

elicoidal · 2018-10-26T07:49:01Z

@sbidoul maybe can help

bizzappdev · 2018-10-26T08:36:22Z

@elicoidal it is failing for travis_makepot not sure what and why
@sbidoul help needed

sbidoul · 2018-10-26T09:17:34Z

makepot failed to push to github because in the meantime another commit (the readme update) was made.

But that commit triggered a new travis build which itself succeeded: https://github.com/OCA/apps-store/commits/11.0

So all is well.

sbidoul · 2018-10-26T09:18:13Z

Shall I install this on odoo-community.org?

elicoidal · 2018-10-27T06:36:07Z

@sbidoul yes please 😄

bizzappdev · 2018-10-27T07:13:58Z

@sbidoul @gurneyalex along with the update on the odoo-community.org.

we have to update the latest code for interface-github repo also as OCA/interface-github#30 as the current PR is depending upon this
we have to fix the old products.
for that we have to execute a server action for the same
Please find the detail of the server action as below.
Detail of server action
Model: product.template
Action To Do Execute Python Code
Python code.

for rec in record:
    if len(rec.attribute_line_ids) != 1:
        continue
    att_list = []
    blank_list = []
    for att in rec.attribute_line_ids:
        if not att.value_ids:
            continue
        att_list.append([1, att.id, {'value_ids': [[6, 0, att.value_ids.ids]]}])
        blank_list.append([1, att.id, {'value_ids': [[6, 0, []]]}])
    
    rec.write({'attribute_line_ids':blank_list})
    rec.write({'attribute_line_ids':att_list})

As there are missing product variant and odoo module version.
when we will change the value attribute values of the template it will recalculate the odoo module version. in the end, we will have proper products/apps with its module information.

sbidoul · 2018-10-27T14:49:36Z

Installed. The above script is running right now.

sbidoul · 2018-10-27T16:40:45Z

Still running...

elicoidal · 2018-10-28T01:27:25Z

@bizzappdev thanks for the detailed procedure.
I suspect it might take some time as there are about 10K products

sbidoul · 2018-10-28T09:23:37Z

It's done. Can you please check everything is ok?

bizzappdev · 2018-10-28T12:12:06Z

No it is not fixed.. not sure qhy. Do you think we should have screen sharing session or something tomorrow.

sbidoul · 2018-10-28T14:04:38Z

Hm, perhaps because I forgot to upgrade interface-github. I'm relaunching the script.

* [IMP] while clean the odoo module version archive the product * [FIX]Added new line at the end of file * [FIX] fix some typo * [IMP]improve logic with less iterations

bizzappdev added 2 commits October 15, 2018 21:05

[IMP] while clean the odoo module version archive the product

3833f36

[FIX]Added new line at the end of file

00c63f5

elicoidal approved these changes Oct 15, 2018

View reviewed changes

elicoidal added the needs review label Oct 15, 2018

elicoidal added this to the 12.0 milestone Oct 15, 2018

[FIX] fix some typo

7d39f75

legalsylvain approved these changes Oct 17, 2018

View reviewed changes

bizzappdev closed this Oct 17, 2018

bizzappdev reopened this Oct 17, 2018

elicoidal approved these changes Oct 17, 2018

View reviewed changes

elicoidal modified the milestones: 12.0, 11.0 Oct 17, 2018

elicoidal added the approved label Oct 17, 2018

oscarolar reviewed Oct 22, 2018

View reviewed changes

[IMP]improve logic with less iterations

95fa60c

elicoidal approved these changes Oct 25, 2018

View reviewed changes

oscarolar approved these changes Oct 25, 2018

View reviewed changes

elicoidal merged commit 235b013 into OCA:11.0 Oct 26, 2018

		@@ -0,0 +1,25 @@
		# Copyright (C) 2017-Today: Odoo Community Association (OCA)

[IMP] while clean the odoo module version archive the product #36

[IMP] while clean the odoo module version archive the product #36

Conversation

bizzappdev commented Oct 15, 2018

bizzappdev commented Oct 15, 2018

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal Oct 15, 2018

Choose a reason for hiding this comment

elicoidal Oct 15, 2018

Choose a reason for hiding this comment

legalsylvain commented Oct 15, 2018

bizzappdev commented Oct 16, 2018

bizzappdev commented Oct 17, 2018

legalsylvain left a comment

Choose a reason for hiding this comment

bizzappdev commented Oct 17, 2018

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal commented Oct 17, 2018

bizzappdev commented Oct 22, 2018

oscarolar Oct 22, 2018 • edited Loading

Choose a reason for hiding this comment

elicoidal Oct 25, 2018

Choose a reason for hiding this comment

bizzappdev Oct 25, 2018

Choose a reason for hiding this comment

elicoidal Oct 25, 2018

Choose a reason for hiding this comment

bizzappdev Oct 25, 2018

Choose a reason for hiding this comment

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal commented Oct 25, 2018

oscarolar commented Oct 25, 2018

oscarolar left a comment

Choose a reason for hiding this comment

elicoidal commented Oct 26, 2018

bizzappdev commented Oct 26, 2018

elicoidal commented Oct 26, 2018

bizzappdev commented Oct 26, 2018

elicoidal commented Oct 26, 2018 via email

elicoidal commented Oct 26, 2018

bizzappdev commented Oct 26, 2018

sbidoul commented Oct 26, 2018

sbidoul commented Oct 26, 2018

elicoidal commented Oct 27, 2018

bizzappdev commented Oct 27, 2018 • edited Loading

sbidoul commented Oct 27, 2018

sbidoul commented Oct 27, 2018

elicoidal commented Oct 28, 2018

sbidoul commented Oct 28, 2018

bizzappdev commented Oct 28, 2018

sbidoul commented Oct 28, 2018

oscarolar Oct 22, 2018 •

edited

Loading

bizzappdev commented Oct 27, 2018 •

edited

Loading