Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] account_reconcile_oca: Use receivable/payable account on statements with partner as suspense account #677

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

etobella
Copy link
Member

With this change, it sets the proper account automatically

@pedrobaeza
Copy link
Member

Steps to reproduce the problem?

@etobella
Copy link
Member Author

It was not actually a problem. With the original solution, if I add a new statement.line related to a partner, the suspense account will be the suspense account of the Journal. With the new change, in this case will get the right receivable or payable account of the partner.

It is the behavior we had on 15 and Odoo is promoting on EE

@pedrobaeza pedrobaeza added this to the 17.0 milestone Aug 1, 2024
@pedrobaeza pedrobaeza changed the title [IMP] account_reconcile_oca: Use receivable/payable account on statements with partner as suspense account [17.0][IMP] account_reconcile_oca: Use receivable/payable account on statements with partner as suspense account Aug 1, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, not sure the gain with this move, but it's not the usual case anyway.

@etobella
Copy link
Member Author

etobella commented Aug 1, 2024

Well, it is how it worked and we lost that functionality from reconcile_widget to account_reconcile_oca. Someone noticed and I made the change because it wasn't too much 😄

@pedrobaeza
Copy link
Member

Yeah, now I see:

Peek 2024-08-01 09-08

but it was so insignificant, as that old line doesn't serve for anything if you don't click or manually create a line. What I miss is to have the suspense line as grey to know that "you have to do an action".

@JordiBForgeFlow
Copy link
Member

I agree with @pedrobaeza. In enterprise the account stays as suspense account, but from a UI perspective it shows the receivable/payable. Weird.

But it's not a problem to show the suspense account because when reconciling with a line, it will be changed right? Perhaps the issue is when you don't want to reconcile with a line but keep the amount in the default partner receivable/payable account. Then you must remember this account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants