-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] account_reconcile_sale_order #666
base: 15.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, LGTM
@gjotten note the customer asked for a few changes, so I demoted this to a draft meanwhile |
Answering on behalf: The mentioned changes should be done soon, in best case this Friday. Afterwards we are going to use it in production and see how well it works or if any other issue emerges. |
yet to do:
That's all small things in the backend, and I expect most work for the migration to be moving the JS part to owl, so it seems fine to me to already start with that. |
@gjotten now I consider this done with some refactoring for easier extension, customer comments pending though. Pushed this as a fixup commit to make it simple for you to add to your migration. Please ping me when I can squash this |
@hbrunn go right ahead with squashing this. |
@gjotten for your migration the latest commit will fix weird unbalanced errors when your customer uses inclusive taxes |
@hbrunn unfortunately our part here is moot since with EE users, we couldn't go forward with introducing OCA reconciliation. |
dadfa14
to
0a6e743
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This module allows a workflow where you don't invoice sale orders until
you've received a payment.
That's useful ie for webshops with non-instant payment like wire
transfer, where you might have a lot of customers not doing the payment
after all, which results in extra work for cancellation of the
invoices/orders involved.
Configuration
To configure this module, you need to:
Usage
To use this module, you need to:
invoicable sale order
Note the reconciliation only works if fully invoicing the sale order
yields an invoice over the order's total amount. Usually this means that
all products in the sale order must have invoicing policy Ordered
quantities.