Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [MIG] purchase_stock_picking_return_invoicing #991

Conversation

mariadforgeflow
Copy link
Contributor

Standard migration to v14
@MiquelRForgeFlow

JordiBForgeFlow and others added 30 commits August 24, 2021 11:57
Remove purchase_open_qty dependency and cleanup module and tests.
…eturned field

This field is computed very slow with previous code. I have improved the speed through
several techniques like read_group and shared prefetching. It might be less readable,
but incredibly faster compared with the previous code.
Currently translated at 100,0% (7 of 7 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-purchase_stock_picking_return_invoicing/de/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
…pute code

We don't need to add dependencies to the method `_get_invoiced`, as the qty_received
field is touched when returning a picking with the option `to_refund` marked

We need also to touch the computation method, as we were not using float_compare
method nor taking into account products with purchase invoicing policy as
"ordered quantities".
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/de/
Currently translated at 100.0% (9 of 9 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/pt_BR/
- Show "Auto-Complete" field in supplier refunds to allow refunding
multiple orders.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (10 of 10 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-13.0/account-invoicing-13.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (10 of 10 strings)

Translation: account-invoicing-13.0/account-invoicing-13.0-purchase_stock_picking_return_invoicing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-purchase_stock_picking_return_invoicing/es/
@mariadforgeflow mariadforgeflow force-pushed the 14.0-mig-purchase_stock_picking_return_invoicing branch from 4861f11 to 4f24f1c Compare August 25, 2021 09:21
@mariadforgeflow mariadforgeflow force-pushed the 14.0-mig-purchase_stock_picking_return_invoicing branch from 4f24f1c to 2c885b5 Compare August 25, 2021 09:39
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-mig-purchase_stock_picking_return_invoicing branch 6 times, most recently from bf271bb to f162c58 Compare August 25, 2021 14:42
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 14.0-mig-purchase_stock_picking_return_invoicing branch from f162c58 to b9a78f6 Compare August 25, 2021 15:18
Copy link

@DavidBForgeFlow DavidBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot. LGTM.

Copy link

@RaulOForgeFlow RaulOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM. Just wondering because there is this symbol in the view
2021-09-23_16-51
:

@MiquelRForgeFlow
Copy link
Contributor

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that is a minor thing, then 👍 .

@pedrobaeza
Copy link
Member

pedrobaeza commented Sep 27, 2021

The asterisk is there because it's not true that it's the returned qty. It's the returned qty that you have marked to be invoiced. The help field also explains it.

Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge!

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-991-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c3f613b into OCA:14.0 Oct 8, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7e7d4c8. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 14.0-mig-purchase_stock_picking_return_invoicing branch October 8, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.