-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] [MIG] purchase_stock_picking_return_invoicing #991
[14.0] [MIG] purchase_stock_picking_return_invoicing #991
Conversation
Remove purchase_open_qty dependency and cleanup module and tests.
…eturned field This field is computed very slow with previous code. I have improved the speed through several techniques like read_group and shared prefetching. It might be less readable, but incredibly faster compared with the previous code.
Currently translated at 100,0% (7 of 7 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-purchase_stock_picking_return_invoicing/de/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
…pute code We don't need to add dependencies to the method `_get_invoiced`, as the qty_received field is touched when returning a picking with the option `to_refund` marked We need also to touch the computation method, as we were not using float_compare method nor taking into account products with purchase invoicing policy as "ordered quantities".
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (8 of 8 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/de/
Currently translated at 100.0% (9 of 9 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/pt_BR/
- Show "Auto-Complete" field in supplier refunds to allow refunding multiple orders.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-13.0/account-invoicing-13.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-purchase_stock_picking_return_invoicing/es/
4861f11
to
4f24f1c
Compare
purchase_stock_picking_return_invoicing/readme/CONTRIBUTORS.rst
Outdated
Show resolved
Hide resolved
purchase_stock_picking_return_invoicing/tests/test_purchase_stock_picking_return_invoicing.py
Outdated
Show resolved
Hide resolved
purchase_stock_picking_return_invoicing/tests/test_purchase_stock_picking_return_invoicing.py
Outdated
Show resolved
Hide resolved
purchase_stock_picking_return_invoicing/views/purchase_view.xml
Outdated
Show resolved
Hide resolved
purchase_stock_picking_return_invoicing/views/purchase_view.xml
Outdated
Show resolved
Hide resolved
4f24f1c
to
2c885b5
Compare
bf271bb
to
f162c58
Compare
f162c58
to
b9a78f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runbot. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v11: Who knows, it was put by @pedrobaeza in 5481332#diff-c01a80d339d66395b2b2362492df10cc443e15832ca25a07cd1dd177efbfb6deR110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that is a minor thing, then 👍 .
The asterisk is there because it's not true that it's the returned qty. It's the returned qty that you have marked to be invoiced. The help field also explains it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge!
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 7e7d4c8. Thanks a lot for contributing to OCA. ❤️ |
Standard migration to v14
@MiquelRForgeFlow