[12.0][MIG] account_global_discount: Migration to 12.0 #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuelcalerosolis you can review this one if you want. |
|
ok, I will be delighted to review it. |
|
In the functional test I have detected inappropriate behavior:
|
pedrobaeza
force-pushed
the
12.0-mig-account_global_discount
branch
from
70208b0 to
bfbd329
Compare
|
@carlosdauden problem fixed |
| @@ -0,0 +1,124 @@ | |||
| <section class="oe_container"> | |||
There was a problem hiding this comment.
This file is quite incomplete.
There was a problem hiding this comment.
Well, it will be generated on merge, although I usually pre-generate it, but not sure if this time it wasn't done.
Give discounts info in the invoice report.
- We need to take into account invoice lines with multiple taxes, so the link should be m2m. - Migration scripts for preserving the best information on existing installations. - Tests for checking new conditions. - Perform sanity check for not ending in an incompatible situation. - Some refactor done on onchanges for avoiding duplicating operations. - Adjust UI for not allowing to edit computed invoice global discounts.
- Standard procedure - Make test more resilient
pedrobaeza
force-pushed
the
12.0-mig-account_global_discount
branch
from
bfbd329 to
f59aaca
Compare
|
@manuelcalerosolis index.html regenerated. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at f5bf9eb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT24294