[FIX] account_invoice_fixed_discount: Fixed devision by zero error to… #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please review this PR and let me know any updates are needed from my end ? I see the failed checks but seems it's related other module, Please advice!
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… v17.0
Case: When an invoice line includes a product with a unit price of 0 and a fixed discount is applied (even by mistake), it results in a traceback error.
Sometimes users may not be aware of the proper configurations for applying discounts. If this occurs, the system prevents further entry and shows a traceback.
This scenario has already been addressed in sale_fixed_discount previously.