Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

Open
wants to merge 23 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] : Migration partner_invoicing_mode to 18.0 #1833

wants to merge 23 commits into from

Conversation

chaule97
Copy link

@chaule97 chaule97 commented Nov 6, 2024 •
edited
Loading

  • If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so we avoid it as possible and define the readonly attribute on the views instead.

TDu and others added 21 commits November 4, 2024 15:55
@TDu @chaule97
[MIG] rename account_invoice_base_invoicing_mode
5d05c35
@chaule97
[UPD] Update partner_invoicing_mode.pot
8fb161d
@StefanRijnhart @chaule97
[MIG] partner_invoicing_mode: Migration to 16.0
e5e36c6 
[UPD] Update partner_invoicing_mode.pot

[UPD] README.rst

partner_invoicing_mode 16.0.1.0.1
@Ivorra78 @chaule97
Added translation using Weblate (Spanish)
eada505 
Translated using Weblate (Spanish)

Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/es/

[UPD] README.rst
@mymage @chaule97
Added translation using Weblate (Italian)
69cdf80 
Translated using Weblate (Italian)

Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/
@rousseldenis @chaule97
[REF] partner_invoicing_mode/monthly: Better extension mechanism
aa03e98 
Allow to have a better extension mechanism when having multiple invoicing
modes.
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Partition invoicings
161b244 
The field one_invoice_per_order wasn't used correctly.

So, now, create invoices using the partner option by calling
the grouping option on sale orders
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Add a field for next invoice date
ad5e612
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Add the invoicing grouping on sale
e831f77 
To improve flexibility, the invoicing grouping option could be different
on the sale order level than on the partner level.
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Add some hooks
0506490
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Don't loop search on sale orders
a7e97ee 
As the read_group() can aggregate sale order ids per partner,
use the ids list instead.
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Don't set next_invoice_date as commerci…
a4d5537 
…al field

As a company can have several different invoicing address, invoicing can occur at different
dates.
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Update the invoice date just after crea…
caba280 
…tion

As validation jobs could last long time if there are plenty, ensure that
the wanted date is correctly set.
@rousseldenis @chaule97
[IMP] partner_invoicing_mode: Use core grouping function in sale module
e5c7c8d 
In order to be able to benefits from standard grouping function, override it
and add missing keys.

[UPD] Update partner_invoicing_mode.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/

Translated using Weblate (Italian)

Currently translated at 94.4% (17 of 18 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (18 of 18 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/it/

Translated using Weblate (Spanish)

Currently translated at 100.0% (18 of 18 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode/es/
@NICO-SOLUTIONS @chaule97
[IMP] partner_invoicing_mode: pre-commit auto fixes
66c748a
@NICO-SOLUTIONS @chaule97
[MIG] partner_invoicing_mode: Migration to 17.0
e2515a3
@chaule97
[UPD] Update partner_invoicing_mode.pot
85b0085
@OCA-git-bot @chaule97
[BOT] post-merge updates
1509e6c
@weblate @chaule97
Update translation files
3714ad7 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-17.0/account-invoicing-17.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-partner_invoicing_mode/
@mymage @chaule97
Translated using Weblate (Italian)
19d57f9 
Currently translated at 100.0% (18 of 18 strings)

Translation: account-invoicing-17.0/account-invoicing-17.0-partner_invoicing_mode
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-17-0/account-invoicing-17-0-partner_invoicing_mode/it/
@chaule97
[IMP] partner_invoicing_mode: pre-commit auto fixes
9d4c8d7
TDu
TDu reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think there is an issue with the sale dependency that is not installed...
image
So I would think the change on sale.order view is not applied ?

@TDu
Copy link
Member

TDu commented Nov 6, 2024 •
edited
Loading

Actually, I think there is an issue with the sale dependency that is not installed... image So I would think the change on sale.order view is not applied ?
Finally installing the sale_management app and it works, so looks good 🤔
Yeah forget about my comment 🫨 sale was installed.

mmequignon
mmequignon reviewed Nov 7, 2024
View reviewed changes
partner_invoicing_mode/tests/test_invoice_mode.py Outdated
@@ -6,7 +6,8 @@
from freezegun import freeze_time

from odoo import fields
from odoo.tests.common import Form, TransactionCase
from odoo.tests import Form
from odoo.tests.common import TransactionCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why CommonPartnerInvoicingMove isn't depending on TransactionCase?
It implements setUpClass and calls super() which no parent class implements.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated CommonPartnerInvoicingMove depending on TransactionCase

@chaule97 chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 2f73859 to 03a1367 Compare November 8, 2024 02:50
@chaule97 chaule97 mentioned this pull request Nov 8, 2024
Open
@chaule97 chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 03a1367 to 2a89ba9 Compare November 8, 2024 07:50
@chaule97
Copy link
Author

chaule97 commented Nov 8, 2024

Hello everyone, I have changed a little about readonly attribute in model and field

@chaule97 chaule97 mentioned this pull request Nov 8, 2024
Open
@chaule97 chaule97 requested a review from mmequignon November 20, 2024 10:33
@TDu
Copy link
Member

TDu commented Nov 22, 2024

base_partition has been mergedhttps://github.com/OCA/server-tools/pull/3077 that DON'T MERGE commit can be removed. Thanks

@chaule97 chaule97 force-pushed the 18.0-mig-partner_invoicing_mode branch from 2a89ba9 to a108a3f Compare November 22, 2024 17:53
@chaule97
Copy link
Author

base_partition has been mergedhttps://github.com/OCA/server-tools/pull/3077 that DON'T MERGE commit can be removed. Thanks

I have removed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu approved these changes

@mmequignon mmequignon Awaiting requested review from mmequignon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@chaule97 @TDu @mmequignon @StefanRijnhart @Ivorra78 @mymage @rousseldenis @NICO-SOLUTIONS @OCA-git-bot @weblate