Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_invoice_line_sequence #1565

Merged
merged 31 commits into from
May 3, 2024
Merged

[15.0][MIG] account_invoice_line_sequence #1565

merged 31 commits into from
May 3, 2024

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Sep 27, 2023

No description provided.

@hbrunn
Copy link
Member Author

hbrunn commented Sep 27, 2023

/ocabot migration account_invoice_line_sequence

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Sep 27, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 27, 2023
Open
56 tasks
@bosd
Copy link
Contributor

bosd commented Oct 5, 2023

Thanks for this!!
Kindly check your last commit. It only includes changes in documentation.

Functional test failed.. Sequence # stays 0.

@hbrunn
Copy link
Member Author

hbrunn commented Oct 5, 2023

did you commit your line? The number is only generated when there's actually a line to save

@bosd
Copy link
Contributor

bosd commented Oct 5, 2023

Picture says more then words :)
Here's some feedback on the testing..

1301cadf-6ae5-4397-8423-c0f3c04309db.webm

Also tried an alternative method.
Enter 1 line.. While entering data sequence number shows as 1.
click save.
Sequence number changes to 0.
Expected behaviour: Sequence # stays 0
screenity (11).webm

Adding a second line after the save.
The first line sequence changes to 1.
Second line is number 2.
Expected behaviour: Having consistency number e.g. always start numbers with either 0 or 1.
screenity (12).webm

@AaronHForgeFlow
Copy link
Contributor

This needs to be included: #1431

serpentcs-dev1 and others added 23 commits November 29, 2023 17:26
@serpentcs-dev1 @hbrunn
[ADD] account_invoice_line_sequence v10 (OCA#282)
794104c 
* [MIG] account_invoice_line_sequence v10

* [IMP] post_init_hook
@oca-transbot @hbrunn
OCA Transbot updated translations from Transifex
0a046bc
@amcor @hbrunn
[MIG] account_invoice_line_sequence: Migration to 11.0
07bac7b
@oca-travis @hbrunn
[UPD] Update account_invoice_line_sequence.pot
244c1f9
@OCA-git-bot @hbrunn
[ADD] icon.png
fdaa626
@MiquelRForgeFlow @hbrunn
[MIG] account_invoice_line_sequence: Migration to 12.0
1f2dea6
@oca-travis @hbrunn
[UPD] Update account_invoice_line_sequence.pot
ad7dc4b
@OCA-git-bot @hbrunn
[UPD] README.rst
acbe102
@oca-transbot @hbrunn
Update translation files
1f19ded 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_sequence/
@oca-transbot @hbrunn
Update translation files
f557437 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_sequence/
@mkrajaci @hbrunn
Update report_invoice.xml
14224d4 
On line 9 was the wrong iterator name. "l" needs to be line.
@hbrunn
Translated using Weblate (Portuguese (Brazil))
e6fb8a3 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_sequence/pt_BR/
@OCA-git-bot @hbrunn
account_invoice_line_sequence 12.0.1.1.0
07dbd53
@marylla @hbrunn
Translated using Weblate (German)
0738ec0 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_sequence/de/
@sysadminmatmoz @hbrunn
Translated using Weblate (Slovenian)
44cd7c5 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_sequence/sl/
@hbrunn
Translated using Weblate (Italian)
d156446 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_sequence/it/
@anasuarez1 @hbrunn
Translated using Weblate (Spanish)
eeb5ed8 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_sequence
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_sequence/es/
@thomaspaulb @hbrunn
[IMP] account_invoice_line_sequence: black, isort, prettier
360e0c1
@thomaspaulb @hbrunn
[MIG] account_invoice_line_sequence 13.0
bf9c66c
@thomaspaulb @hbrunn
[IMP] account_invoice_line_sequence README
97d237e
@hbrunn
[UPD] Update account_invoice_line_sequence.pot
eda6127
@OCA-git-bot @hbrunn
[UPD] README.rst
3cedf33
@hbrunn
[IMP] account_invoice_line_sequence: black, isort, prettier
84c5915
@hbrunn hbrunn force-pushed the 15.0-mig-account_invoice_line_sequence branch from d87784e to c416ef4 Compare November 29, 2023 16:26
@hbrunn
Copy link
Member Author

hbrunn commented Nov 29, 2023

@AaronHForgeFlow thanks for the headsup, but I rewrote this part (we don't touch the sequence field now, which causes the problems in v14) slightly, so I doubt we need this here. Actually, I think it would be more elegant to backport what I do here instead of having to activate the module after installation, which I always find a bit weird.

@bosd thanks for the elaboration, could you retest?

@hbrunn hbrunn force-pushed the 15.0-mig-account_invoice_line_sequence branch from c416ef4 to 5342af8 Compare November 29, 2023 16:30
@hbrunn hbrunn mentioned this pull request Nov 29, 2023
Closed
bosd
bosd approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test LGTM!

@AaronHForgeFlow
Copy link
Contributor

@hbrunn sorry, I did not see the refactor on that part. I agree this is more consistent solution

@bosd
Copy link
Contributor

bosd commented Apr 28, 2024

@AaronHForgeFlow can you please review?

AaronHForgeFlow
AaronHForgeFlow approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 🟢

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1565-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 208d187 into OCA:15.0 May 3, 2024
2 of 3 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ab0db6a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.