[15.0][FIX] sale_timesheet_invoice_description: Fix tests according to qty_delivered compute change since #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delivered compute change since odoo/odoo@12355a8
pedrobaeza
approved these changes
May 12, 2023
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at be2dda9. Thanks a lot for contributing to OCA. ❤️ |
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests according to
qty_deliveredcompute change since odoo/odoo@12355a8Before,
qty_deliveredwas calculated by summing up the analytical lines and converting withuom_idNow,
qty_deliveredis computed by iterating each analytical lines and converting withuom_ideach line.This change of behavior, causes in some use cases that the rounding makes it differ by 0.01 (or more in some cases).
Please @pedrobaeza can you review it?
@Tecnativa