Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][mig]-account_invoice_line_description #1403

Merged
merged 24 commits into from
Oct 20, 2023
Merged

[15.0][mig]-account_invoice_line_description #1403

merged 24 commits into from
Oct 20, 2023

Conversation

JuanyDForgeflow
Copy link

No description provided.

@rafaelbn
Copy link
Member

rafaelbn commented Mar 1, 2023

/ocabot migration account_invoice_line_description

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 1, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 1, 2023
Open
56 tasks
AaronHForgeFlow
AaronHForgeFlow reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the code the description in the product is the only thing that should appear in the invoice line as label. However it is appearing a compound name, for example, for a sales order of a product with name "Widget" and description for sales "this is a widget" the label in the invoice line is "Widget this is a widget". Is that intended?

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 5, 2023
Closed
@pedrobaeza
Copy link
Member

/ocabot migration account_invoice_line_description

@OCA-git-bot
Copy link
Contributor

The migration issue (#1022) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1409.
Perhaps you should check that there is no duplicate work.
CC : @bizzappdev

@rafaelbn
Copy link
Member

Please @JuanyDForgeflow could you answer @AaronHForgeFlow ?

tafaRU and others added 20 commits October 20, 2023 10:57
@tafaRU @AaronHForgeFlow
Rename module to account_invoice_line_description
048e2d4
@tafaRU @AaronHForgeFlow
account_invoice_line_description: fix description set on invoice line…
6ef051f 
…s; use description_sale or description_purchase depending on the invoice type
@luismontalba @AaronHForgeFlow
[MIG] account_invoice_line_description: Migrated to 10.0
6007713
@yajo @AaronHForgeFlow
[FIX] account_invoice_line_description: Pass integration tests
c8a5d66 
This addon test fails if the `sale` addon is installed, with:

    ERROR: setUpClass (odoo.addons.account_invoice_line_description.tests.test_account_invoice_line_description.TestAccountInvoiceLineDescription)
    Traceback (most recent call last):
    `   File "/opt/odoo/auto/addons/account_invoice_line_description/tests/test_account_invoice_line_description.py", line 33, in setUpClass
    `     'description_sale': 'Test Description Sale',
    `   File "/opt/odoo/auto/addons/product/models/product.py", line 320, in create
    `     product = super(ProductProduct, self.with_context(create_product_product=True)).create(vals)
    `   File "/opt/odoo/auto/addons/mail/models/mail_thread.py", line 228, in create
    `     thread = super(MailThread, self).create(values)
    `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3847, in create
    `     record = self.browse(self._create(old_vals))
    `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3908, in _create
    `     parent_id = self.env[parent_model].create(parent_vals).id
    `   File "/opt/odoo/auto/addons/product/models/product_template.py", line 267, in create
    `     template = super(ProductTemplate, self).create(vals)
    `   File "/opt/odoo/auto/addons/mail/models/mail_thread.py", line 228, in create
    `     thread = super(MailThread, self).create(values)
    `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3847, in create
    `     record = self.browse(self._create(old_vals))
    `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3942, in _create
    `     cr.execute(query, tuple(u[2] for u in updates if len(u) > 2))
    `   File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 154, in wrapper
    `     return f(self, *args, **kwargs)
    `   File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 231, in execute
    `     res = self._obj.execute(query, params)
    ` IntegrityError: null value in column "sale_line_warn" violates not-null constraint
    ` DETAIL:  Failing row contains (41, null, 1.00, null, 1, null, 1, 1, null, null, 2018-05-15 08:03:37.480628, 1, t, t, null, 1, 1, Test Description Sale, null, null, 2018-05-15 08:03:37.480628, t, 7, Test Sale Product, f, consu, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null).
@amcor @AaronHForgeFlow
[MIG] account_invoice_line_description: Migration to 11.0
bc0d8b2
@sbidoul @AaronHForgeFlow
remove obsolete .pot files [ci skip]
d07d6d8
@etobella @AaronHForgeFlow
Translated using Weblate (Spanish)
110601b 
Currently translated at 40.0% (2 of 5 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_line_description
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_line_description/es/
@tafaRU @AaronHForgeFlow
[MIG] account_invoice_line_description: Migration to 12.0
3af1672
@primes2h @AaronHForgeFlow
Translated using Weblate (Italian)
ec4340a 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_description
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_description/it/
@marylla @AaronHForgeFlow
Translated using Weblate (German)
d1a0dc3 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_description
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_description/de/
@josepmy @AaronHForgeFlow
Translated using Weblate (Spanish)
9e56116 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_description
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_description/es/
@AaronHForgeFlow
Translated using Weblate (Portuguese (Brazil))
dfbe806 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_line_description
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_line_description/pt_BR/
@kongrattapong @AaronHForgeFlow
[IMP] account_invoice_line_description: black, isort, prettier
ba6f64f
@kongrattapong @AaronHForgeFlow
[MIG] account_invoice_line_description: Migration to 13.0
6930679
@AaronHForgeFlow
[MIG] account_invoice_line_description: Migration to 14.0
ebfb568
@oca-travis @AaronHForgeFlow
[UPD] Update account_invoice_line_description.pot
f1fbf40
@OCA-git-bot @AaronHForgeFlow
[UPD] README.rst
e7d29f0
@AaronHForgeFlow
[FIX] account_invoice_line_description: unbalanced invoice error in test
522f0d0
@OCA-git-bot @AaronHForgeFlow
account_invoice_line_description 14.0.1.0.1
674f93a
@OCA-git-bot @AaronHForgeFlow
[UPD] README.rst
c3e14ed
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-account_invoice_line_description branch from 91da5ea to 45b051f Compare October 20, 2023 08:58
AaronHForgeFlow
AaronHForgeFlow requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaelbn I checked and in v14 the behaviour is not the same, the product label is not in the description. So that must be fixed.

AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit makes this to behave same as v14. I will wait for others to review before merging it.

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1403-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 070f441 into OCA:15.0 Oct 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e71f956. Thanks a lot for contributing to OCA. ❤️

@AaronHForgeFlow AaronHForgeFlow deleted the 15.0-mig-account_invoice_line_description branch October 20, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.