Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_receipt_journal #1398

Merged
merged 4 commits into from
Mar 7, 2023
Merged

[15.0][MIG] account_receipt_journal #1398

merged 4 commits into from
Mar 7, 2023

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Feb 27, 2023 •
edited
Loading

Straight forward migration + Improvements from #1398 (review)

MT-2035 @moduon @rafaelbn @SirTakobi @eLBati

@Shide Shide force-pushed the 15.0-mig-account_receipt_journal branch from 9e9cc77 to 93e52d5 Compare February 27, 2023 16:25
@rafaelbn
Copy link
Member

/ocabot migration account_receipt_journal

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 27, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 27, 2023
Open
56 tasks
fcvalgar
fcvalgar approved these changes Feb 28, 2023
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review is good.

rafaelbn
rafaelbn requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, after review. I know this is a migration but module is incomplete from my point of view @eLBati @SirTakobi . Explanation with the improvement we should make:

  • Create a Invoice in a Journal that is dedicated for receipts shouldn't happend never. That is the purpose of the module.

  • Actually a user can create from invoicing an invoice in a receipt journal and this shouldn't happend.

@Shide please, improve me module to make it move robust

Video: https://www.loom.com/share/58480c3d895a40169b4b1091a777936d

I guess previous versions they are using it to create from sales or purchase, but our use case is directly by invoicing user (not accountant).

Thank you!

@Shide Shide changed the title [15.0] [MIG] account_receipt_journal [15.0][MIG] account_receipt_journal Mar 1, 2023
@Shide Shide force-pushed the 15.0-mig-account_receipt_journal branch from 3cf33bf to f6347ae Compare March 1, 2023 12:19
@Shide Shide requested a review from rafaelbn March 1, 2023 12:27
@rafaelbn
Copy link
Member

rafaelbn commented Mar 1, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-1398:15.0-mig-account_receipt_journal failed with output:

remote: Permission to moduon/account-invoicing.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/account-invoicing/': The requested URL returned error: 403

@rafaelbn rafaelbn closed this Mar 1, 2023
@rafaelbn rafaelbn reopened this Mar 1, 2023
rafaelbn
rafaelbn approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafaelbn rafaelbn closed this Mar 4, 2023
@rafaelbn rafaelbn reopened this Mar 4, 2023
@rafaelbn
Copy link
Member

rafaelbn commented Mar 4, 2023

@yajo @sbidoul please could you help here with runboat? I mean how can we know hoy to solve with runboat is "pending"? Thank you!

@sbidoul
Copy link
Member

sbidoul commented Mar 4, 2023 •
edited
Loading

Maybe a webhook call got lost. Try pushing a commit on this pr.

@rafaelbn
Copy link
Member

rafaelbn commented Mar 4, 2023

Thank you! @Shide try a commit please

@Shide Shide force-pushed the 15.0-mig-account_receipt_journal branch from f6347ae to ed90a78 Compare March 6, 2023 08:33
@Shide Shide force-pushed the 15.0-mig-account_receipt_journal branch from ed90a78 to 950f90b Compare March 6, 2023 08:50
rafaelbn
rafaelbn approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1398-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d21ba56 into OCA:15.0 Mar 7, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3b834d5. Thanks a lot for contributing to OCA. ❤️

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
@OCA-git-bot
Merge PR OCA#1398 into 14.0
6620139 
Signed-off-by moylop260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Shide @rafaelbn @OCA-git-bot @sbidoul @fcvalgar @eLBati @SirTakobi