Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_invoice_refund_line_selection #1322

Merged
merged 22 commits into from
Jul 17, 2023
Merged

[15.0][MIG] account_invoice_refund_line_selection #1322

merged 22 commits into from
Jul 17, 2023

Conversation

ChrisOForgeFlow
Copy link
Contributor

Standard Migration
@ForgeFlow

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-account_invoice_refund_line_selection branch from 6aa68df to aa27968 Compare December 23, 2022 19:20
@rafaelbn
Copy link
Member

rafaelbn commented Jan 2, 2023

/ocabot migration account_invoice_refund_line_selection

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 2, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 2, 2023
Open
56 tasks
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-account_invoice_refund_line_selection branch from aa27968 to 0f52b69 Compare January 17, 2023 21:04
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-account_invoice_refund_line_selection branch from 0f52b69 to 5bd0770 Compare March 25, 2023 15:34
@RodrigoBM
Copy link

RodrigoBM commented May 25, 2023 •
edited by rafaelbn
Loading

@RodrigoBM
Copy link

add this commit 7844d10

I have seen that the same solution has been added, but I don't know if it is more correct to add the commit of the fix that already exists.

@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-account_invoice_refund_line_selection branch from 5bd0770 to 293cb32 Compare May 25, 2023 19:16
@ChrisOForgeFlow
Copy link
Contributor Author

I believe that migration was done before the commit you refer was merged(#1292), because that commit is not included

@RodrigoBM
Copy link

But the correction Nov 25, 2022 and your migration is from Dec 23, 2022, I understand that you have to add that comit.

@ChrisOForgeFlow
Copy link
Contributor Author

ChrisOForgeFlow commented May 29, 2023 •
edited
Loading

But the correction Nov 25, 2022 and your migration is from Dec 23, 2022, I understand that you have to add that comit.

Yes, commit is Nov 25, but was merged after my PR , because that when I retrieve all history of commit on migration process, this commit was not merged yet

image

@etobella
Copy link
Member

etobella commented Jun 2, 2023

@ChrisOForgeFlow It is not a problem if the PR was merged or not before the creation of the commit. It is a patch that is needed. For this reason, it is interesting to add it.

Actually, it comes from an old PR opened by me #1131 and I forgot to port it to 14. Can you add it manually using cherry-pick, please? 🙏

jarroyomorales and others added 16 commits June 5, 2023 14:42
@ChrisOForgeFlow
[ADD] account_invoice_refund_line
0783ddc
@OCA-git-bot @ChrisOForgeFlow
[ADD] icon.png
1edb115
@ChrisOForgeFlow
[12.0][MIG] account_invoice_refund_line_selection
259e10a
@etobella @ChrisOForgeFlow
[IMP] account_invoice_refund_line_selection: black, isort, prettier
06529d6
@etobella @ChrisOForgeFlow
[MIG] account_invoice_refund_line_selection: Migration to 13.0
f4f0349
@etobella @ChrisOForgeFlow
[IMP] account_invoice_refund_line_selection: Add view for search
462f718
@olgamarcocb @ChrisOForgeFlow
[IMP] account_invoice_refund_line_selection: black, isort, prettier
53743fa
@olgamarcocb @ChrisOForgeFlow
[MIG] account_invoice_refund_line_selection: Migration to 14.0
3b4e07d
@oca-travis @ChrisOForgeFlow
[UPD] Update account_invoice_refund_line_selection.pot
fcc6cb7
@OCA-git-bot @ChrisOForgeFlow
[UPD] README.rst
a87f6e1
@extrememicro @ChrisOForgeFlow
Added translation using Weblate (Catalan)
172218c
@bosd @ChrisOForgeFlow
Added translation using Weblate (Dutch)
00abeaf
@bosd @ChrisOForgeFlow
Translated using Weblate (Dutch)
712a663 
Currently translated at 81.8% (9 of 11 strings)

Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_refund_line_selection
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_refund_line_selection/nl/
@bosd @ChrisOForgeFlow
Translated using Weblate (Dutch)
9684780 
Currently translated at 90.9% (10 of 11 strings)

Translation: account-invoicing-14.0/account-invoicing-14.0-account_invoice_refund_line_selection
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_invoice_refund_line_selection/nl/
@kittiu @ChrisOForgeFlow
account_invoice_refund_line_selection, error singleton
3ee1208
@OCA-git-bot @ChrisOForgeFlow
account_invoice_refund_line_selection 14.0.1.0.1
14b775a
@ChrisOForgeFlow ChrisOForgeFlow force-pushed the 15.0-mig-account_invoice_refund_line_selection branch from 293cb32 to 823fb03 Compare June 5, 2023 19:49
@ChrisOForgeFlow
Copy link
Contributor Author

@ChrisOForgeFlow It is not a problem if the PR was merged or not before the creation of the commit. It is a patch that is needed. For this reason, it is interesting to add it.

Actually, it comes from an old PR opened by me #1131 and I forgot to port it to 14. Can you add it manually using cherry-pick, please? pray

Done! Thank you for explanation

@P4R
Copy link
Member

P4R commented Jun 29, 2023

@rafaelbn @RodrigoBM Could you merge this?

@RodrigoBM
Copy link

ping @rafaelbn i am not psc @P4R

rafaelbn
rafaelbn approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍🏼

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1322-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit e71de8e into OCA:15.0 Jul 17, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 10b049f. Thanks a lot for contributing to OCA. ❤️

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
@OCA-git-bot
Merge PR OCA#1322 into 14.0
1e1732a 
Signed-off-by kittiu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@RodrigoBM RodrigoBM RodrigoBM approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.