[MIG] partner_invoicing_mode, partner_invoicing_mode_at_shipping, partner_invoicing_mode_monthly: Migration to 16.0 #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.
Add few changes from reviews. Use sudo to post the invoice.
Split invoice creation on invoice partner settings that decides if sales order atre being grouped in invoice or not. The previous implementation would crash.
…one_invoice_per_order' to res.partner's _commercial_fields()
Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.
If we group several sales in the same procurement group, we'll invoice only one sale order. Tracing back to the sales through the stock moves ensure we invoice all of them.
Through the stock moves
Add few changes from reviews. Use sudo to post the invoice.
Split invoice creation on invoice partner settings that decides if sales order atre being grouped in invoice or not. The previous implementation would crash.
Filter out sales order that have nothing to invoice. To avoid an exception at invoice createion.
Add explicit message if nothing is invoiced
StefanRijnhart
force-pushed
the
16.0-mig-partner_invoicing_mode
branch
2 times, most recently
from
8f34450 to
081c661
Compare
StefanRijnhart
force-pushed
the
16.0-mig-partner_invoicing_mode
branch
from
081c661 to
0b70968
Compare
|
Hello @StefanRijnhart , Should be different PR per module? I guess is inteded to make a single PR 😄 /ocabot migration partner_invoicing_mode /ocabot migration partner_invoicing_mode_at_shipping /ocabot migration partner_invoicing_mode_monthly |
|
@rafaelbn I think having a single PR is better than three PRs that depend on each other, having to juggle temporary git locations as test requirements. As you can see, I grouped the migration commits per module for easy review. |
TDu
approved these changes
Dec 15, 2022
houssine78
approved these changes
Apr 18, 2023
|
@pedrobaeza a last one here :) thanks again ! |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 578c809. Thanks a lot for contributing to OCA. ❤️ |
odooNextev
pushed a commit
to odooNextev/account-invoicing
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From unmerged PRs #1243, #1245 and #1247, in which the modules were renamed from account_invoice_base_invoicing_mode, account_invoicing_mode_at_shipping and account_invoice_base_invoicing_mode_monthly respectively.
Standard migration, with increased coverage in all modules.