Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][mig] account_invoice_blocking #1265

Merged
merged 26 commits into from
Oct 26, 2022
Merged

[15.0][mig] account_invoice_blocking #1265

merged 26 commits into from
Oct 26, 2022

Conversation

JordiBForgeFlow
Copy link
Member

Standard migration

ThomasBinsfeld and others added 25 commits October 17, 2022 07:34
@ThomasBinsfeld @JordiBForgeFlow
account_invoice_blocking (OCA#170)
942a8dc 
[ADD] account_invoice_blocking
@adrienpeiffer @JordiBForgeFlow
Migration of account_invoice_blocking to 10.0
aeb6c60
@sbidoul @JordiBForgeFlow
website URI in setup.py
b4f8d50
@astirpe @JordiBForgeFlow
account_invoice_blocking: migration to V11
900a153
@JordiBForgeFlow
Added translation using Weblate (Dutch)
d1eb814
@JordiBForgeFlow
Translated using Weblate (Dutch)
3c0e307 
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_blocking
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_blocking/nl/
@Nikul-Chaudhary @JordiBForgeFlow
[MIG] account_invoice_blocking v11 to v12
2983086
@badbole @JordiBForgeFlow
Added translation using Weblate (Croatian)
20b4d9b
@badbole @JordiBForgeFlow
Translated using Weblate (Croatian)
5dff49f 
Currently translated at 50.0% (2 of 4 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_blocking
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_blocking/hr/
@marylla @JordiBForgeFlow
Added translation using Weblate (German)
8e017a1
@marylla @JordiBForgeFlow
Translated using Weblate (German)
9cd9c50 
Currently translated at 50.0% (2 of 4 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_blocking
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_blocking/de/
@anasuarez1 @JordiBForgeFlow
Added translation using Weblate (Spanish)
debe0ad
@anasuarez1 @JordiBForgeFlow
Translated using Weblate (Spanish)
681b969 
Currently translated at 75.0% (3 of 4 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_blocking
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_blocking/es/
@marcelsavegnago @JordiBForgeFlow
Added translation using Weblate (Portuguese (Brazil))
4cfbde5
@pedrocs-exo @JordiBForgeFlow
Added translation using Weblate (Portuguese)
d9f8a90
@pedrocs-exo @JordiBForgeFlow
Translated using Weblate (Portuguese)
99172db 
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_blocking
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_blocking/pt/
@etobella @JordiBForgeFlow
[IMP] account_invoice_blocking: black, isort, prettier
eb7ebf1
@etobella @JordiBForgeFlow
[MIG] account_invoice_blocking: Migration to 13.0
2696d28
@olgamarcocb @JordiBForgeFlow
[IMP] account_invoice_blocking: black, isort, prettier
8121593
@olgamarcocb @JordiBForgeFlow
[MIG] account_invoice_blocking: Migration to 14.0
44e5198
@oca-travis @JordiBForgeFlow
[UPD] Update account_invoice_blocking.pot
6fdbf58
@OCA-git-bot @JordiBForgeFlow
[UPD] README.rst
4f96598
@willytal @JordiBForgeFlow
[FIX] account_invoice_blocking: fix tests
d32f374 
TT32113
@OCA-git-bot @JordiBForgeFlow
account_invoice_blocking 14.0.1.0.1
73816d3
@JordiBForgeFlow
[IMP] account_invoice_blocking: black, isort, prettier
f2a4354
PieterPaulussen
PieterPaulussen suggested changes Oct 18, 2022
View reviewed changes
Copy link

@PieterPaulussen PieterPaulussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few conventions that can be easily applied, otherwise this looks good to me.

account_invoice_blocking/models/account_move.py Outdated
from odoo import api, fields, models


class AccountInvoice(models.Model):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a more suitable name would be

Suggested change
class AccountInvoice(models.Model):
class AccountMove(models.Model):

account_invoice_blocking/models/account_move.py Outdated
all(line.blocked for line in move_lines) if move_lines else False
)

blocked = fields.Boolean(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this field is best defined right below the models' private attributes like _inherit instead of at the bottom of the file.

account_invoice_blocking/views/account_move.xml Outdated
<!-- Copyright 2016 Acsone SA/NV
License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
<odoo>
<record id="account_invoice_form_view" model="ir.ui.view">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<record id="account_invoice_form_view" model="ir.ui.view">
<record id="view_move_form" model="ir.ui.view">

@JordiBForgeFlow JordiBForgeFlow force-pushed the 15.0-mig-account_invoice_blocking branch from 6b79ac3 to 7d79e94 Compare October 26, 2022 05:12
@JordiBForgeFlow
Copy link
Member Author

@PieterPaulussen thanks for your feedback. I have applied your suggestions.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiBForgeFlow
Copy link
Member Author

/ocabot migration account_invoice_blocking
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 26, 2022
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1265-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 26, 2022
Open
56 tasks
@OCA-git-bot OCA-git-bot merged commit b0a3ce0 into OCA:15.0 Oct 26, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fd75499. Thanks a lot for contributing to OCA. ❤️

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
@OCA-git-bot
Merge PR OCA#1265 into 14.0
785274d 
Signed-off-by AaronHForgeFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PieterPaulussen PieterPaulussen PieterPaulussen approved these changes

@adrienpeiffer adrienpeiffer adrienpeiffer approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.