15.0 mig purchase stock picking return invoicing #1162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove purchase_open_qty dependency and cleanup module and tests.
…eturned field This field is computed very slow with previous code. I have improved the speed through several techniques like read_group and shared prefetching. It might be less readable, but incredibly faster compared with the previous code.
Currently translated at 100,0% (7 of 7 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-purchase_stock_picking_return_invoicing/de/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
…pute code We don't need to add dependencies to the method `_get_invoiced`, as the qty_received field is touched when returning a picking with the option `to_refund` marked We need also to touch the computation method, as we were not using float_compare method nor taking into account products with purchase invoicing policy as "ordered quantities".
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (8 of 8 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/de/
Currently translated at 100.0% (9 of 9 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/pt_BR/
- Show "Auto-Complete" field in supplier refunds to allow refunding multiple orders.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-purchase_stock_picking_return_invoicing/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-13.0/account-invoicing-13.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-purchase_stock_picking_return_invoicing/
Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-purchase_stock_picking_return_invoicing/es/
…counter We should hide the view refunds button when there are no refunds, not when there aren't invoices. It hasn't been detected till now, because you usually have an invoice before doing a refund, but in case you include this purchase order in a vendor refund, you won't get any vendor bill. TT32388
…s for refund auto-complet Previous attrs was showing the auto-complete field on customer invoices and refunds as well. This commit also simplifies the expression, as the copied version from upstream contains a non-sense domain (`purchase` state doesn't exist). TT33192
Currently translated at 100.0% (10 of 10 strings) Translation: account-invoicing-14.0/account-invoicing-14.0-purchase_stock_picking_return_invoicing Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-purchase_stock_picking_return_invoicing/pt_BR/
26hpredraglazarevic
force-pushed
the
15.0-mig-purchase_stock_picking_return_invoicing
branch
from
5ac464a to
57e1a71
Compare
|
@pedrobaeza @MiquelRForgeFlow hi guys, since I'm first-time contributor could you please approve workflows, so checks can run. Also if you are available to do code review, that would be much appreciated. Thank you in advance. |
|
Only @OCA/community-maintainers can approve workflows. |
56 tasks
Thanks for the info Miguel. @OCA/community-maintainers since I'm first-time contributor could you please approve workflows, so checks can run. Also if you are available to do code review, that would be much appreciated. Thank you in advance. |
|
Approved |
|
@pedrobaeza can u help me with this pull request, who do I contact regarding Review. Three tests that are failing are:
|
|
For the super missing, just include the return, although no value is returned on super: def _get_invoiced(self):
res = super()._get_invoiced()
return resThe problem in the tests seems something outside this PR. |
|
@26hpredraglazarevic please could you rebase? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Already migrated to 15 in #1169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.