Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] [MIG] account_invoice_tax_note #1146

Merged
merged 7 commits into from
May 4, 2022

Conversation

Shide
Copy link
Contributor

@Shide Shide commented May 3, 2022

Standard migration

  • Bumped version
  • Fixed report
  • Squashed tranlsation and adminstrative commits

@yajo @rafaelbn please review if you want 😄

MT-656 @moduon

@Shide Shide force-pushed the 15.0-mig-account_invoice_tax_note branch from 4cffa4b to 3159c8f Compare May 3, 2022 09:04
@Shide
Copy link
Contributor Author

Shide commented May 3, 2022

@HaraldPanten
Copy link

HaraldPanten commented May 3, 2022

Tests are passing: https://github.com/OCA/account-invoicing/runs/6270654711?check_suite_focus=true#step:8:156

You should FIX the failure for the other module. Sorry 😔

@rafaelbn
Copy link
Member

rafaelbn commented May 3, 2022

/ocabot migration account_invoice_tax_note

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone May 3, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request May 3, 2022
56 tasks
@rafaelbn
Copy link
Member

rafaelbn commented May 3, 2022

So,

2022-05-03 09:07:06,623 265 ERROR odoo unittest.suite: ERROR: setUpClass (odoo.addons.account_invoice_fiscal_position_update.tests.test_inv_fiscal_pos_update.TestProductIdChange)
Traceback (most recent call last):
  File "/opt/odoo/addons/account/tests/common.py", line 31, in setUpClass
    assert 'post_install' in cls.test_tags, 'This test requires a CoA to be installed, it should be tagged "post_install"'
AssertionError: This test requires a CoA to be installed, it should be tagged "post_install"

Migrated to v15 here: [MIG] account_invoice_fiscal_position_update: Migration to 15.0 #1084
Later Added FIX to tests in v14 here: [14.0][FIX] account_invoice_fiscal_position_update: fix tests #1141

2022-05-03 09:07:13,401 265 ERROR odoo unittest.suite: ERROR: setUpClass (odoo.addons.account_invoice_tax_required.tests.test_account_move_tax_required.TestAccountInvoiceTaxRequired)
Traceback (most recent call last):
  File "/opt/odoo/addons/account/tests/common.py", line 524, in setUpClass
    super().setUpClass(chart_template_ref=chart_template_ref)
  File "/opt/odoo/addons/account/tests/common.py", line 31, in setUpClass
    assert 'post_install' in cls.test_tags, 'This test requires a CoA to be installed, it should be tagged "post_install"'
AssertionError: This test requires a CoA to be installed, it should be tagged "post_install"

Migrated to v15 here: [15.0][MIG] account_invoice_tax_required #1086

This FIX talk also about "post_install" --> [15.0][FIX] account_asset_management: add post-install tagged #1387

Super thanks! 🤟

@etobella
Copy link
Member

etobella commented May 3, 2022

Can you rebase?

@yajo
Copy link
Member

yajo commented May 4, 2022

Rebasing won't fix it, the 15.0 branch is broken. We need to forward-port #1141 as @rafaelbn said.

@Shide
Copy link
Contributor Author

Shide commented May 4, 2022

Tests are passing in this migration and runboat is working perfectly.
Why to wait to another unexisting PR to merge this one?

@etobella
Copy link
Member

etobella commented May 4, 2022

Done on #1148

@rafaelbn
Copy link
Member

rafaelbn commented May 4, 2022

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1146-by-rafaelbn-bump-patch, awaiting test results.

@rafaelbn
Copy link
Member

rafaelbn commented May 4, 2022

@etobella @HaraldPanten all 💚 😄 Ready!! 🚀

@OCA-git-bot OCA-git-bot merged commit fd0ab05 into OCA:15.0 May 4, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 002b247. Thanks a lot for contributing to OCA. ❤️

@rafaelbn
Copy link
Member

rafaelbn commented May 4, 2022

Sorry @etobella @HaraldPanten , I call bot by mistake thinking it had a triple validation (I change so quickly of tab), I try to stop de merge but I don't know how. I tried to close de PR and open again but bot didn't stop after closing de PR 😢 . Lucky is that all was 🟢 and working!

@etobella
Copy link
Member

etobella commented May 4, 2022

Don't worry, It looked fine 😄

@HaraldPanten
Copy link

@rafaelbn to abort the merging process:

See that when bot is merging, a new branch is created. In this PR, the new branch was called 15.0-ocabot-merge-pr-1146-by-rafaelbn-bump-patch

If you want to cancel the merging process, you need to delete the new branch created by the bot. So... you should had deleted 15.0-ocabot-merge-pr-1146-by-rafaelbn-bump-patch before the PR was merged.

After this step, the merging process will stop and you can continue working on the PR. Once you want to merge, you can write the bot merge commands as usual.

Hope it could be helpful.

PS: I know this because I had to abort some merging processes due to self mistakes. 🤓😂

@Shide Shide deleted the 15.0-mig-account_invoice_tax_note branch May 4, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants