-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0] [MIG] account_invoice_tax_note #1146
[15.0] [MIG] account_invoice_tax_note #1146
Conversation
[ADD] icon.png
[UPD] README.rst
[FIX] Change xpath expression
4cffa4b
to
3159c8f
Compare
You should FIX the failure for the other module. Sorry 😔 |
/ocabot migration account_invoice_tax_note |
So,
Migrated to v15 here: [MIG] account_invoice_fiscal_position_update: Migration to 15.0 #1084
Migrated to v15 here: [15.0][MIG] account_invoice_tax_required #1086 This FIX talk also about "post_install" --> [15.0][FIX] account_asset_management: add post-install tagged #1387 Super thanks! 🤟 |
Can you rebase? |
Rebasing won't fix it, the 15.0 branch is broken. We need to forward-port #1141 as @rafaelbn said. |
Tests are passing in this migration and runboat is working perfectly. |
Done on #1148 |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@etobella @HaraldPanten all 💚 😄 Ready!! 🚀 |
Congratulations, your PR was merged at 002b247. Thanks a lot for contributing to OCA. ❤️ |
Sorry @etobella @HaraldPanten , I call bot by mistake thinking it had a triple validation (I change so quickly of tab), I try to stop de merge but I don't know how. I tried to close de PR and open again but bot didn't stop after closing de PR 😢 . Lucky is that all was 🟢 and working! |
Don't worry, It looked fine 😄 |
@rafaelbn to abort the merging process: See that when bot is merging, a new branch is created. In this PR, the new branch was called 15.0-ocabot-merge-pr-1146-by-rafaelbn-bump-patch If you want to cancel the merging process, you need to delete the new branch created by the bot. So... you should had deleted 15.0-ocabot-merge-pr-1146-by-rafaelbn-bump-patch before the PR was merged. After this step, the merging process will stop and you can continue working on the PR. Once you want to merge, you can write the bot merge commands as usual. Hope it could be helpful. PS: I know this because I had to abort some merging processes due to self mistakes. 🤓😂 |
Standard migration
@yajo @rafaelbn please review if you want 😄
MT-656 @moduon