Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] account_invoice_refund_line_selection: prepare refund vals #1127

Conversation

Abranes
Copy link
Member

@Abranes Abranes commented Apr 5, 2022

Call the Odoo base function _prepare_refund because this function implements that logic and some other modules inherit it to add more data.

For example the module account_invoice_pricelist in this same repository which adds pricelist_id to account.invoice and inherits _prepare_refund to pass the pricelist_id when you create a refund. With the current code we miss the pricelist when we create a refund but with this changes we preserve this value and all others.

Call the Odoo base function `_prepare_refund` because this function implements that logic and some other modules inherit it to add more data.
@etobella
Copy link
Member

etobella commented Apr 6, 2022

It was done this way because there are some fields that needed to be recalcualted (like taxes, I am not sure if this will work in all cases 😭 )

@Abranes Abranes closed this Feb 14, 2023
@hildickethan hildickethan deleted the 12.0-fix-account_invoice_regund_line_selection branch November 23, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants