Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] account_invoice_pricelist: Migration to 15.0 #1111

Merged
merged 44 commits into from
Dec 21, 2022

Conversation

nicomacr
Copy link
Contributor

No description provided.

legalsylvain and others added 30 commits March 10, 2022 15:45
OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
Currently translated at 100,0% (5 of 5 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_pricelist
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_pricelist/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_pricelist
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_pricelist/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_pricelist
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_pricelist/fr/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_pricelist
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_pricelist/pt_BR/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_pricelist
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_pricelist/es_CL/
Currently translated at 100.0% (5 of 5 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_pricelist
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_pricelist/hr/
@rafaelbn
Copy link
Member

rafaelbn commented Apr 6, 2022

/ocabot migration account_invoice_pricelist

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 6, 2022
@bhaveshselarka
Copy link

Hello @nicomacr thanks for the migration, Is this ready for merge and production use ??

@marylla
Copy link
Contributor

marylla commented Jun 30, 2022

Hi @nicomacr Could you please rebase? Currently I cannot test it on runboat...

@jabelchi
Copy link
Contributor

jabelchi commented Aug 8, 2022

It's not possible to test it in rumboat.
Am I doing something wrong?

@marylla
Copy link
Contributor

marylla commented Aug 29, 2022

@nicomacr Are you still there to fix this?

@nicomacr
Copy link
Contributor Author

@marylla yes i made the rebase now, but nothing changes in the runboat.

@marylla
Copy link
Contributor

marylla commented Aug 30, 2022

@nicomacr I also cannot see any changes in this communication. Are you sure you rebased and updated this PR?

Copy link
Member

@fkantelberg fkantelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it works fine. Just a small comment regarding the returns in the onchange

account_invoice_pricelist/models/account_move.py Outdated Show resolved Hide resolved
Copy link

@navarrorico navarrorico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Copy link
Contributor

@jabelchi jabelchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on runboat, OK.

@marylla
Copy link
Contributor

marylla commented Dec 20, 2022

I tested it locally and it works fine. Just a small comment regarding the returns in the onchange

@nicomacr Could you check this please? :)

@grindtildeath
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1111-by-grindtildeath-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3ea0d9b into OCA:15.0 Dec 21, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1749fd2. Thanks a lot for contributing to OCA. ❤️

@nicomacr nicomacr deleted the 15.0-t-26333-nmr2 branch December 21, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.