Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] account_invoice_tree_currency: Migration to 15.0 #1043

Merged
merged 8 commits into from
Feb 21, 2022
Merged

[15.0][MIG] account_invoice_tree_currency: Migration to 15.0 #1043

merged 8 commits into from
Feb 21, 2022

Conversation

OriolVForgeFlow
Copy link

No description provided.

@OriolVForgeFlow
Copy link
Author

@ForgeFlow

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase, let's see if the new runboat triggers.

@OriolVForgeFlow OriolVForgeFlow force-pushed the 15.0-mig-account_invoice_tree_currency branch from 17787fa to 8755bbf Compare December 3, 2021 11:21
@OriolVForgeFlow OriolVForgeFlow force-pushed the 15.0-mig-account_invoice_tree_currency branch from 8755bbf to 2112bbf Compare December 29, 2021 13:05
@OriolVForgeFlow OriolVForgeFlow force-pushed the 15.0-mig-account_invoice_tree_currency branch from 2112bbf to 0b2b265 Compare December 29, 2021 14:55
JoanMForgeFlow
JoanMForgeFlow approved these changes Jan 7, 2022
View reviewed changes
Copy link

@JoanMForgeFlow JoanMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK! 👍 Functional LG

@dreispt
Copy link
Member

dreispt commented Feb 6, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1043-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 6, 2022
@OCA-git-bot
Merge PR #1043 into 15.0
142601b 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1043-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@houssine78
Copy link

Hi @OriolVForgeFlow could you try a rebase to see if runboat go green ?

@dreispt
Copy link
Member

dreispt commented Feb 21, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1043-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aeebc58 into OCA:15.0 Feb 21, 2022
@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-account_invoice_tree_currency branch February 21, 2022 14:50
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b7dd786. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow
Copy link
Contributor

/ocabot migration account_invoice_tree_currency

@OCA-git-bot
Copy link
Contributor

Sorry @MiquelRForgeFlow you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@pedrobaeza
Copy link
Member

/ocabot migration account_invoice_tree_currency

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 21, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 21, 2022
Open
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houssine78 houssine78 houssine78 approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@JoanMForgeFlow JoanMForgeFlow JoanMForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
10 participants
@OriolVForgeFlow @dreispt @OCA-git-bot @houssine78 @MiquelRForgeFlow @pedrobaeza @HaraldPanten @JoanMForgeFlow @oca-travis @fredzamoabg